Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2112783002: Use ChannelMojo for the Browser-GPU IPC channel. (Closed)

Created:
4 years, 5 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ChannelMojo for the Browser-GPU IPC channel. BUG=604282 Committed: https://crrev.com/4e48b26d830f640f59a754c26d9b79525548faad Cr-Commit-Position: refs/heads/master@{#404000}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 5 chunks +8 lines, -7 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (6 generated)
Anand Mistry (off Chromium)
WDYT?
4 years, 5 months ago (2016-06-30 05:51:29 UTC) #2
piman
LGTM in principle, but could we land this after the branch?
4 years, 5 months ago (2016-06-30 15:24:31 UTC) #3
piman
On 2016/06/30 15:24:31, piman wrote: > LGTM in principle, but could we land this after ...
4 years, 5 months ago (2016-06-30 15:26:37 UTC) #4
Anand Mistry (off Chromium)
On 2016/06/30 15:26:37, piman wrote: > On 2016/06/30 15:24:31, piman wrote: > > LGTM in ...
4 years, 5 months ago (2016-07-01 00:54:44 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112783002/1
4 years, 5 months ago (2016-07-05 00:14:28 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-05 01:01:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112783002/20001
4 years, 5 months ago (2016-07-07 00:08:16 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 00:13:53 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4e48b26d830f640f59a754c26d9b79525548faad Cr-Commit-Position: refs/heads/master@{#404000}
4 years, 5 months ago (2016-07-07 00:15:25 UTC) #15
phoglund_chromium
4 years, 5 months ago (2016-07-07 09:33:30 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2124143003/ by phoglund@chromium.org.

The reason for reverting is: Breaks
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)...,
possibly also WebKit GPU tests.

Powered by Google App Engine
This is Rietveld 408576698