Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Issue 2127693002: Use ChannelMojo for GpuChannels. (Closed)

Created:
4 years, 5 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo-channel-gpu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ChannelMojo for GpuChannels. BUG=604282 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/cef5cfa8e1e017d0818979d820ea77023d50fd11 Cr-Commit-Position: refs/heads/master@{#406719}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rbase update #

Patch Set 4 : Make socket handle optional. #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 1 chunk +1 line, -4 lines 0 comments Download
M gpu/ipc/service/gpu_channel.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_channel.cc View 1 2 3 4 5 2 chunks +8 lines, -13 lines 0 comments Download
M gpu/ipc/service/gpu_channel_test_common.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Anand Mistry (off Chromium)
Now with 100% more controversy.
4 years, 5 months ago (2016-07-07 01:46:48 UTC) #3
Anand Mistry (off Chromium)
Ping!
4 years, 5 months ago (2016-07-20 05:00:15 UTC) #4
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-20 05:22:37 UTC) #7
piman
LGTM - sorry, I don't think I received the original email, somehow.
4 years, 5 months ago (2016-07-20 23:10:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127693002/100001
4 years, 5 months ago (2016-07-20 23:30:05 UTC) #12
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-20 23:30:06 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-07-21 00:10:09 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 00:14:45 UTC) #16
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/cef5cfa8e1e017d0818979d820ea77023d50fd11
Cr-Commit-Position: refs/heads/master@{#406719}

Powered by Google App Engine
This is Rietveld 408576698