Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: Source/devtools/front_end/HeapSnapshot.js

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/HeapSnapshot.js
diff --git a/Source/devtools/front_end/HeapSnapshot.js b/Source/devtools/front_end/HeapSnapshot.js
index 736d02a36082b383d66dfc7138ab73e20afdccc0..9116d5c980a9914787332c93ebd31b6065af11e0 100644
--- a/Source/devtools/front_end/HeapSnapshot.js
+++ b/Source/devtools/front_end/HeapSnapshot.js
@@ -64,14 +64,13 @@ WebInspector.HeapSnapshotEdge = function(snapshot, edgeIndex)
* @param {!WebInspector.HeapSnapshotNode.Serialized} node
* @param {number} nodeIndex
* @param {string} type
- * @param {number} distance
*/
-WebInspector.HeapSnapshotEdge.Serialized = function(name, node, nodeIndex, type, distance) {
+WebInspector.HeapSnapshotEdge.Serialized = function(name, node, nodeIndex, type)
+{
this.name = name;
this.node = node;
this.nodeIndex = nodeIndex;
this.type = type;
- this.distance = distance;
};
WebInspector.HeapSnapshotEdge.prototype = {
@@ -147,7 +146,7 @@ WebInspector.HeapSnapshotEdge.prototype = {
serialize: function()
{
var node = this.node();
- return new WebInspector.HeapSnapshotEdge.Serialized(this.name(), node.serialize(), this.nodeIndex(), this.type(), node.distance());
+ return new WebInspector.HeapSnapshotEdge.Serialized(this.name(), node.serialize(), this.nodeIndex(), this.type());
},
_type: function()
@@ -311,14 +310,12 @@ WebInspector.HeapSnapshotRetainerEdge = function(snapshot, retainerIndex)
* @param {!WebInspector.HeapSnapshotNode.Serialized} node
* @param {number} nodeIndex
* @param {string} type
- * @param {number} distance
*/
-WebInspector.HeapSnapshotRetainerEdge.Serialized = function(name, node, nodeIndex, type, distance) {
+WebInspector.HeapSnapshotRetainerEdge.Serialized = function(name, node, nodeIndex, type) {
this.name = name;
this.node = node;
this.nodeIndex = nodeIndex;
this.type = type;
- this.distance = distance;
}
WebInspector.HeapSnapshotRetainerEdge.prototype = {
@@ -430,7 +427,7 @@ WebInspector.HeapSnapshotRetainerEdge.prototype = {
serialize: function()
{
var node = this.node();
- return new WebInspector.HeapSnapshotRetainerEdge.Serialized(this.name(), node.serialize(), this.nodeIndex(), this.type(), node.distance());
+ return new WebInspector.HeapSnapshotRetainerEdge.Serialized(this.name(), node.serialize(), this.nodeIndex(), this.type());
},
/**
« no previous file with comments | « LayoutTests/inspector/profiler/heap-snapshot-test.js ('k') | Source/devtools/front_end/HeapSnapshotDataGrids.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698