Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: LayoutTests/inspector/profiler/heap-snapshot-containment-show-all.html

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector/profiler/heap-snapshot-containment-show-all.html
diff --git a/LayoutTests/inspector/profiler/heap-snapshot-containment-show-all.html b/LayoutTests/inspector/profiler/heap-snapshot-containment-show-all.html
index 6083da0a1b45d91b4785fdbcd4015f38fe60d677..d497b09ffe2d80688d6e1820402e74ef5b98707e 100644
--- a/LayoutTests/inspector/profiler/heap-snapshot-containment-show-all.html
+++ b/LayoutTests/inspector/profiler/heap-snapshot-containment-show-all.html
@@ -105,16 +105,16 @@ function test()
function step3(row)
{
- InspectorTest.assertEquals("(GC roots)", row.data.object.value, "(GC roots) object");
- InspectorTest.assertEquals(0, row.data.distance, "(GC roots) distance should be zero");
+ InspectorTest.assertEquals("(GC roots)", row._name, "(GC roots) object");
+ InspectorTest.assertEquals(0, row._distance, "(GC roots) distance should be zero");
InspectorTest.findAndExpandWindow(step4);
}
function step4(row)
{
- InspectorTest.assertEquals("Window", row.data.object.value, "Window object");
- InspectorTest.assertEquals(distance, row.data.distance, "Window distance should be 1");
- var child = InspectorTest.findRow("object", function (obj) { return obj.name === "next"; }, row);
+ InspectorTest.assertEquals("Window", row._name, "Window object");
+ InspectorTest.assertEquals(distance, row._distance, "Window distance should be 1");
+ var child = InspectorTest.findMatchingRow(function (obj) { return obj._referenceName === "next"; }, row);
InspectorTest.assertEquals(true, !!child, "next found");
InspectorTest.expandRow(child, step5);
}
@@ -122,16 +122,16 @@ function test()
function step5(row)
{
++distance;
- InspectorTest.assertEquals(distance, row.data.distance, "Check distance of objects chain");
- if (row.data.object.value === "Tail") {
+ InspectorTest.assertEquals(distance, row._distance, "Check distance of objects chain");
+ if (row._name === "Tail") {
InspectorTest.assertEquals(7, distance, "Tail distance");
setTimeout(next, 0);
return;
}
- InspectorTest.assertEquals("Body", row.data.object.value, "Body");
- var child = InspectorTest.findRow("object", function (obj) { return obj.name === "next"; }, row);
+ InspectorTest.assertEquals("Body", row._name, "Body");
+ var child = InspectorTest.findMatchingRow(function (obj) { return obj._referenceName === "next"; }, row);
InspectorTest.assertEquals(true, !!child, "next found");
- if (child.data.object.value !== "Tail")
+ if (child._name !== "Tail")
InspectorTest.expandRow(child, step5);
else
step5(child);

Powered by Google App Engine
This is Rietveld 408576698