Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: LayoutTests/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html
diff --git a/LayoutTests/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html b/LayoutTests/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html
index 80c29bf7f366cc6afc679e0bec2ce8b6e9601705..1bda5ebe2545823309303ce297d50e1d48abcb4a 100644
--- a/LayoutTests/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html
+++ b/LayoutTests/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html
@@ -38,7 +38,7 @@ function test()
function step3()
{
- var row = InspectorTest.findRow("object", "B");
+ var row = InspectorTest.findRow("B");
InspectorTest.assertEquals(true, !!row, "\"B\" row");
InspectorTest.expandRow(row, showNext);
function showNext(row)
@@ -51,13 +51,13 @@ function test()
function step4()
{
- var row = InspectorTest.findRow("object", "B");
+ var row = InspectorTest.findRow("B");
InspectorTest.assertEquals(true, !!row, "\"B\" row");
function deletedNodeMatcher(data)
{
- return data.removedCount && data.object.value.charAt(0) === "B";
+ return data._isDeletedNode && data._name.charAt(0) === "B";
}
- var bInstanceRow = InspectorTest.findRow2(deletedNodeMatcher, row);
+ var bInstanceRow = InspectorTest.findMatchingRow(deletedNodeMatcher, row);
InspectorTest.assertEquals(true, !!bInstanceRow, "\"B\" instance row");
var buttonsNode = InspectorTest.findButtonsNode(row, bInstanceRow);
InspectorTest.assertEquals(false, !!buttonsNode, "buttons node found!");

Powered by Google App Engine
This is Rietveld 408576698