Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2112683002: Null-check ThreadTaskRunnerHandle::Get() before doing Connect() in BC::Init() (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Null-check ThreadTaskRunnerHandle::Get() before doing Connect() in BC::Init() R=rockot@chromium.org BUG= Committed: https://crrev.com/21a34c257e212c729c91dedb4dbaf1da2369e594 Cr-Commit-Position: refs/heads/master@{#402954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/browser_context.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Ben Goodger (Google)
4 years, 5 months ago (2016-06-29 20:57:11 UTC) #1
Ken Rockot(use gerrit already)
Oof. A little unfortunate, but seems legit enough for me.
4 years, 5 months ago (2016-06-29 21:09:22 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 5 months ago (2016-06-29 21:09:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112683002/1
4 years, 5 months ago (2016-06-29 21:17:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 22:24:54 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 22:26:01 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 22:27:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21a34c257e212c729c91dedb4dbaf1da2369e594
Cr-Commit-Position: refs/heads/master@{#402954}

Powered by Google App Engine
This is Rietveld 408576698