Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: gpu/command_buffer/service/feature_info.cc

Issue 2112513003: gpu: Use workarounds to selectively enable CMAA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/feature_info.h" 5 #include "gpu/command_buffer/service/feature_info.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <set> 9 #include <set>
10 #include <vector> 10 #include <vector>
(...skipping 874 matching lines...) Expand 10 before | Expand all | Expand 10 after
885 extensions.Contains("GL_EXT_multisample_compatibility")) { 885 extensions.Contains("GL_EXT_multisample_compatibility")) {
886 AddExtensionString("GL_EXT_multisample_compatibility"); 886 AddExtensionString("GL_EXT_multisample_compatibility");
887 feature_flags_.ext_multisample_compatibility = true; 887 feature_flags_.ext_multisample_compatibility = true;
888 validators_.capability.AddValue(GL_MULTISAMPLE_EXT); 888 validators_.capability.AddValue(GL_MULTISAMPLE_EXT);
889 validators_.capability.AddValue(GL_SAMPLE_ALPHA_TO_ONE_EXT); 889 validators_.capability.AddValue(GL_SAMPLE_ALPHA_TO_ONE_EXT);
890 } 890 }
891 891
892 if (extensions.Contains("GL_INTEL_framebuffer_CMAA")) { 892 if (extensions.Contains("GL_INTEL_framebuffer_CMAA")) {
893 feature_flags_.chromium_screen_space_antialiasing = true; 893 feature_flags_.chromium_screen_space_antialiasing = true;
894 AddExtensionString("GL_CHROMIUM_screen_space_antialiasing"); 894 AddExtensionString("GL_CHROMIUM_screen_space_antialiasing");
895 } else if (enable_cmaa_shaders_switch_ && 895 } else if ((enable_cmaa_shaders_switch_ ||
Zhenyao Mo 2016/06/29 16:59:16 You should just get rid of this enable_cmaa_shader
robert.bradford 2016/06/29 17:39:46 Done.
896 !workarounds_.disable_framebuffer_cmaa) &&
896 (gl_version_info_->IsAtLeastGLES(3, 1) || 897 (gl_version_info_->IsAtLeastGLES(3, 1) ||
897 (gl_version_info_->IsAtLeastGL(3, 0) && 898 (gl_version_info_->IsAtLeastGL(3, 0) &&
898 extensions.Contains("GL_ARB_shading_language_420pack") && 899 extensions.Contains("GL_ARB_shading_language_420pack") &&
899 extensions.Contains("GL_ARB_texture_gather") && 900 extensions.Contains("GL_ARB_texture_gather") &&
900 extensions.Contains("GL_ARB_explicit_uniform_location") && 901 extensions.Contains("GL_ARB_explicit_uniform_location") &&
901 extensions.Contains("GL_ARB_explicit_attrib_location") && 902 extensions.Contains("GL_ARB_explicit_attrib_location") &&
902 extensions.Contains("GL_ARB_shader_image_load_store")))) { 903 extensions.Contains("GL_ARB_shader_image_load_store")))) {
903 feature_flags_.chromium_screen_space_antialiasing = true; 904 feature_flags_.chromium_screen_space_antialiasing = true;
904 feature_flags_.use_chromium_screen_space_antialiasing_via_shaders = true; 905 feature_flags_.use_chromium_screen_space_antialiasing_via_shaders = true;
905 AddExtensionString("GL_CHROMIUM_screen_space_antialiasing"); 906 AddExtensionString("GL_CHROMIUM_screen_space_antialiasing");
(...skipping 509 matching lines...) Expand 10 before | Expand all | Expand 10 after
1415 if (pos == std::string::npos) { 1416 if (pos == std::string::npos) {
1416 extensions_ += (extensions_.empty() ? "" : " ") + str; 1417 extensions_ += (extensions_.empty() ? "" : " ") + str;
1417 } 1418 }
1418 } 1419 }
1419 1420
1420 FeatureInfo::~FeatureInfo() { 1421 FeatureInfo::~FeatureInfo() {
1421 } 1422 }
1422 1423
1423 } // namespace gles2 1424 } // namespace gles2
1424 } // namespace gpu 1425 } // namespace gpu
OLDNEW
« no previous file with comments | « no previous file | gpu/config/gpu_driver_bug_list_json.cc » ('j') | gpu/config/gpu_driver_bug_list_json.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698