Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2112493003: Fix racing which may pause gpu process's interface registry forever (Closed)

Created:
4 years, 5 months ago by kcwu
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Owen Lin, piman+watch_chromium.org, Pawel Osciak
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix racing which may pause gpu process's interface registry forever AcceptConnection and OnInitialize are racing. Only pause the interface registry if OnInitialize is not invoked. TEST=arc video playback well BUG=620845 Committed: https://crrev.com/baef2ce0540b155429c40995bd88000bb9b6487f Cr-Commit-Position: refs/heads/master@{#403185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M content/gpu/gpu_child_thread.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
kcwu
4 years, 5 months ago (2016-06-30 10:36:22 UTC) #2
kcwu
This fixes issue introduced by https://codereview.chromium.org/2108343002. PTAL, thanks.
4 years, 5 months ago (2016-06-30 10:37:43 UTC) #3
Ken Rockot(use gerrit already)
Thanks, lgtm
4 years, 5 months ago (2016-06-30 13:22:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112493003/1
4 years, 5 months ago (2016-06-30 14:55:00 UTC) #6
Ben Goodger (Google)
lgtm
4 years, 5 months ago (2016-06-30 14:59:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112493003/1
4 years, 5 months ago (2016-06-30 15:36:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 15:41:16 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 15:41:23 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 15:44:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/baef2ce0540b155429c40995bd88000bb9b6487f
Cr-Commit-Position: refs/heads/master@{#403185}

Powered by Google App Engine
This is Rietveld 408576698