Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2108343002: Defer Mojo interface binding in the gpu process until OnInitialize (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Defer Mojo interface binding in the gpu process until OnInitialize Prevents the GPU process's browser-facing InterfaceRegistry from dispatching incoming interface requests until GpuChildThread::OnInitialize has been invoked. BUG=620845 R=ben@chromium.org Committed: https://crrev.com/caccf78eb490815d2cf6f0daea68b6cf4c153302 Cr-Commit-Position: refs/heads/master@{#402996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M content/gpu/gpu_child_thread.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M services/shell/public/cpp/interface_registry.h View 2 chunks +10 lines, -0 lines 0 comments Download
M services/shell/public/cpp/lib/interface_registry.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ken Rockot(use gerrit already)
4 years, 5 months ago (2016-06-29 21:13:01 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 5 months ago (2016-06-29 21:25:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108343002/1
4 years, 5 months ago (2016-06-29 22:03:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 23:39:33 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 23:40:00 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 23:43:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/caccf78eb490815d2cf6f0daea68b6cf4c153302
Cr-Commit-Position: refs/heads/master@{#402996}

Powered by Google App Engine
This is Rietveld 408576698