Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2112443002: [debugger] Simplify deletion of DeoptimizedFrameInfo. (Closed)

Created:
4 years, 5 months ago by titzer
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer, Jarin, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] Simplify deletion of DeoptimizedFrameInfo. R=yangguo@chromium.org,jarin@chromium.org BUG= Committed: https://crrev.com/4a8ac723aebd286889a7677f12bb5cca9cf70434 Cr-Commit-Position: refs/heads/master@{#37377}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M src/debug/debug-frames.cc View 1 chunk +2 lines, -4 lines 1 comment Download
M src/deoptimizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
titzer
4 years, 5 months ago (2016-06-29 08:50:11 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-06-29 08:54:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112443002/1
4 years, 5 months ago (2016-06-29 08:56:08 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18344)
4 years, 5 months ago (2016-06-29 09:27:01 UTC) #6
Yang
On 2016/06/29 09:27:01, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 5 months ago (2016-06-29 09:33:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112443002/1
4 years, 5 months ago (2016-06-29 09:35:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 09:43:03 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4a8ac723aebd286889a7677f12bb5cca9cf70434 Cr-Commit-Position: refs/heads/master@{#37377}
4 years, 5 months ago (2016-06-29 09:45:03 UTC) #12
Benedikt Meurer
4 years, 5 months ago (2016-06-29 09:56:45 UTC) #14
Message was sent while issue was closed. 
https://codereview.chromium.org/2112443002/diff/1/src/debug/debug-frames.cc
File src/debug/debug-frames.cc (right):

https://codereview.chromium.org/2112443002/diff/1/src/debug/debug-frames.cc#n...
src/debug/debug-frames.cc:36: if (deoptimized_frame_ != nullptr) {
You don't need this check, delete already does a nullptr check.

Powered by Google App Engine
This is Rietveld 408576698