Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: src/debug/debug-frames.cc

Issue 2112443002: [debugger] Simplify deletion of DeoptimizedFrameInfo. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/deoptimizer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug-frames.cc
diff --git a/src/debug/debug-frames.cc b/src/debug/debug-frames.cc
index b1a8af256934d3e5d8ba93c49a9bce0d7c5e8d62..e683fa2d15c0fd11a8515d52ebe1c907ca7d5fd1 100644
--- a/src/debug/debug-frames.cc
+++ b/src/debug/debug-frames.cc
@@ -31,15 +31,13 @@ FrameInspector::FrameInspector(JavaScriptFrame* frame,
}
}
-
FrameInspector::~FrameInspector() {
// Get rid of the calculated deoptimized frame if any.
- if (deoptimized_frame_ != NULL) {
- Deoptimizer::DeleteDebuggerInspectableFrame(deoptimized_frame_, isolate_);
+ if (deoptimized_frame_ != nullptr) {
Benedikt Meurer 2016/06/29 09:56:45 You don't need this check, delete already does a n
+ delete deoptimized_frame_;
}
}
-
int FrameInspector::GetParametersCount() {
return is_optimized_ ? deoptimized_frame_->parameters_count()
: frame_->ComputeParametersCount();
« no previous file with comments | « no previous file | src/deoptimizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698