Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 211233002: Tweak compare_codereview.py. (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 9 months ago
Reviewers:
hal.canary, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Tweak compare_codereview.py. - summary at end so I don't have to scroll back up - tweak the diff markers a bit - strip the test runtimes BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M tools/compare_codereview.py View 3 chunks +21 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 9 months ago (2014-03-25 14:04:45 UTC) #1
hal.canary
LGTM. I don't think the rest of the team will mind the format change. One ...
6 years, 9 months ago (2014-03-25 14:08:45 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-25 14:09:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/211233002/1
6 years, 9 months ago (2014-03-25 14:09:20 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 15:16:33 UTC) #5
Message was sent while issue was closed.
Change committed as 13935

Powered by Google App Engine
This is Rietveld 408576698