Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: tools/compare_codereview.py

Issue 211233002: Tweak compare_codereview.py. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/compare_codereview.py
diff --git a/tools/compare_codereview.py b/tools/compare_codereview.py
index ae2909611e4d5f0c142f422b64372d81f79c42e2..b39bfe2942bb7b687b07ba32a3689c77a3cf1284 100755
--- a/tools/compare_codereview.py
+++ b/tools/compare_codereview.py
@@ -336,22 +336,6 @@ def main(control_url, roll_url, verbosity=1):
roll_name = '[roll %s]' % roll_url.split('/')[-1]
out = sys.stdout
- if verbosity > 0:
- # Print out summary of all of the bots.
- out.write('%11s %11s %4s %s\n\n' %
- ('CONTROL', 'ROLL', 'DIFF', 'BOT'))
- for bot in sorted(all_bots):
- if control[bot].status != roll[bot].status:
- diff = '****'
- elif (control[bot].status != 'success' or
- roll[bot].status != 'success'):
- diff = '....'
- else:
- diff = ''
- out.write('%11s %11s %4s %s\n' % (
- control[bot].status, roll[bot].status, diff, bot))
- out.write('\n')
- out.flush()
for bot in sorted(all_bots):
if (roll[bot].status == 'success'):
@@ -371,6 +355,8 @@ def main(control_url, roll_url, verbosity=1):
for result in results:
formatted_result = re.sub(
r'(\S*\.html) ', '\n__\g<1>\n', result.text)
+ # Strip runtimes.
+ formatted_result = re.sub(r'\(.*\)', '', formatted_result)
printer(2, formatted_result)
if ('compile' in result.text
or '...and more' in result.text):
@@ -380,6 +366,25 @@ def main(control_url, roll_url, verbosity=1):
printer(2, status)
out.write('\n')
+ if verbosity > 0:
+ # Print out summary of all of the bots.
+ out.write('%11s %11s %4s %s\n\n' %
+ ('CONTROL', 'ROLL', 'DIFF', 'BOT'))
+ for bot in sorted(all_bots):
+ if roll[bot].status == 'success':
+ diff = ''
+ elif (control[bot].status == 'success' and
+ roll[bot].status == 'failure'):
+ diff = '!!!!'
+ elif ('pending' in control[bot].status or
+ 'pending' in roll[bot].status):
+ diff = '....'
+ else:
+ diff = '****'
+ out.write('%11s %11s %4s %s\n' % (
+ control[bot].status, roll[bot].status, diff, bot))
+ out.write('\n')
+ out.flush()
if __name__ == '__main__':
if len(sys.argv) < 3:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698