Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: ui/base/gtk/owned_widget_gtk.cc

Issue 21123007: Reenable BrowserTest.WindowOpenClose (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/gtk/owned_widget_gtk.cc
diff --git a/ui/base/gtk/owned_widget_gtk.cc b/ui/base/gtk/owned_widget_gtk.cc
index 6a129a21807cf63f60044089402a4de9a47a2629..2324e53286a32efe7aec455d534c8733d42d2fad 100644
--- a/ui/base/gtk/owned_widget_gtk.cc
+++ b/ui/base/gtk/owned_widget_gtk.cc
@@ -37,8 +37,6 @@ void OwnedWidgetGtk::Destroy() {
gtk_widget_destroy(widget);
DCHECK(!g_object_is_floating(widget));
- // NOTE: Assumes some implementation details about glib internals.
- DCHECK_EQ(G_OBJECT(widget)->ref_count, 1U);
Elliot Glaysher 2013/07/30 18:13:49 While I really really want this line gone (and is
Evan Stade 2013/07/30 22:08:50 This DCHECK is not spurious. It was intentionally
g_object_unref(widget);
}
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698