Reenable BrowserTest.WindowOpenClose

ui/base/gtk/owned_widget_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/gtk/owned_widget_gtk.h"
 
 #include <gtk/gtk.h>
 
 #include "base/logging.h"
 
@@ skipping 19 matching lines @@
 
 void OwnedWidgetGtk::Destroy() {
   if (!widget_)
     return;
 
   GtkWidget* widget = widget_;
   widget_ = NULL;
   gtk_widget_destroy(widget);
 
   DCHECK(!g_object_is_floating(widget));
-  // NOTE: Assumes some implementation details about glib internals.
-  DCHECK_EQ(G_OBJECT(widget)->ref_count, 1U);

[Elliot Glaysher, 2013/07/30 18:13:49]

While I really really want this line gone (and is probably wrong now that Ubuntu
is loading multiple other libraries into our process that hold on to our
widgets), have you discussed this with other people? I don't feel comfortable
dropping this w/o discussion because estade has fought to keep this here.

[Evan Stade, 2013/07/30 22:08:50]

This DCHECK is not spurious. It was intentionally put here and is a large part
of why this class even exists. Without this check, the class serves a different
purpose: it goes from "OwnedWidget" to "ScopedWidgetReference". It has served us
well for years (although yes it can be annoying). The fact that the DCHECK is
being hit 100% of the time indicates that someone's code is wrong.

   g_object_unref(widget);
 }
 
 }  // namespace ui