third_party/WebKit/Source/modules/accessibility/AXObject.h - Issue 2112243004: Ignores ARIA relations (e.g. aria-labelledby) that point to an invisible target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.h

Issue 2112243004: Ignores ARIA relations (e.g. aria-labelledby) that point to an invisible target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed invisible to hidden to match ARIA Implementation Guide. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp ('K') | « third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXObject.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXObject.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.h b/third_party/WebKit/Source/modules/accessibility/AXObject.h

index 8008f4c785812fca57202b268c6e4a4ef4b3a387..7da65fdc65bd841b81729f6fbe95c5c82bd80f32 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObject.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.h

@@ -670,6 +670,7 @@ public:

const AXObject* disabledAncestor() const;

bool lastKnownIsIgnoredValue();

void setLastKnownIsIgnoredValue(bool);

+ bool isHiddenForTextAlternativeCalculation() const;

bool hasInheritedPresentationalRole() const;

bool isPresentationalChild() const;

bool ancestorExposesActiveDescendant() const;

@@ -954,7 +955,6 @@ protected:

// Used only inside textAlternative():

static String collapseWhitespace(const String&);

static String recursiveTextAlternative(const AXObject&, bool inAriaLabelledByTraversal, AXObjectSet& visited);

- bool isHiddenForTextAlternativeCalculation() const;

String ariaTextAlternative(bool recursive, bool inAriaLabelledByTraversal, AXObjectSet& visited, AXNameFrom&, AXRelatedObjectVector*, NameSources*, bool* foundTextAlternative) const;

String textFromElements(bool inAriaLabelledByTraversal, AXObjectSet& visited, HeapVector<Member<Element>>& elements, AXRelatedObjectVector* relatedObjects) const;

void tokenVectorFromAttribute(Vector<String>&, const QualifiedName&) const;