|
|
Created:
6 years, 9 months ago by dstockwell Modified:
6 years, 9 months ago Reviewers:
eseidel CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis Base URL:
svn://svn.chromium.org/blink/trunk Visibility:
Public. |
DescriptionCSS Transforms: Implement backface-visibility
Implements backface-visibility as defined in CSS Transforms[1]. Behavior is
identical to -webkit-backface-visibility.
Note, this property is guarded by the CSSTransformsUnprefixed runtime feature
(enabled only for testing).
[1] http://www.w3.org/TR/css3-transforms/
NOTRY=true
BUG=154772
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170320
Patch Set 1 #Patch Set 2 : Rebase. #Patch Set 3 : Rebase. #Patch Set 4 : Rebase #
Messages
Total messages: 43 (0 generated)
lgtm Where is it guarded?
On 2014/03/25 14:07:38, eseidel wrote: > lgtm > > Where is it guarded? In https://codereview.chromium.org/211033002/ I think it's slightly confusing that we still have both CSSPropertyNames.in and CSSProperties.in, adding to the latter doesn't actually define a new property.
Agreed. CSSPropertyNames.in is the new one used for generating a bunch of previously copy/paste code. We need to get rid of CSSPropertys.in
The CQ bit was checked by dstockwell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/80001
Message was sent while issue was closed.
Change committed as 170021
Message was sent while issue was closed.
A revert of this CL has been created in https://codereview.chromium.org/212563007/ by vsevik@chromium.org. The reason for reverting is: Breaks telemetry_unittests: http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/... Here is how you can run the tests after you build debug chrome: tools/telemetry/run_tests --browser=debug web_components.web_components_unittest.
The CQ bit was checked by dstockwell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by dstockwell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by dstockwell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by dstockwell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by eseidel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/180001
The CQ bit was unchecked by dstockwell@chromium.org
The CQ bit was checked by dstockwell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/200001
The CQ bit was unchecked by dstockwell@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for LayoutTests/transforms/backface-visibility-parsing.html: While running svn copy LayoutTests/transforms/transform-style-parsing.html LayoutTests/transforms/backface-visibility-parsing.html --config-dir /b/commit-queue/subversion_config --non-interactive --username commit-bot@chromium.org; svn: Path 'LayoutTests/transforms/transform-style-parsing.html' does not exist Patch: NR LayoutTests/transforms/transform-style-parsing.html->LayoutTests/transforms/backface-visibility-parsing.html Index: LayoutTests/transforms/backface-visibility-parsing.html diff --git a/LayoutTests/transforms/transform-style-parsing.html b/LayoutTests/transforms/backface-visibility-parsing.html similarity index 55% copy from LayoutTests/transforms/transform-style-parsing.html copy to LayoutTests/transforms/backface-visibility-parsing.html index 1011a63458002b8944a92475df9dd76253eddbed..1fcf6c771014fc96a6a902e1b1a626898e0cf2ba 100644 --- a/LayoutTests/transforms/transform-style-parsing.html +++ b/LayoutTests/transforms/backface-visibility-parsing.html @@ -4,13 +4,13 @@ <div id="target"></div> <script src="resources/parsing-test-helper.js"></script> <script> -expect = expect.bind(this, 'transform-style', 'transformStyle'); +expect = expect.bind(this, 'backface-visibility', 'backfaceVisibility'); -expect('initial').parsesAs('initial').isComputedTo('flat'); +expect('initial').parsesAs('initial').isComputedTo('visible'); expect('inherit').parsesAs('inherit'); -expect('flat').parsesAs('flat').isComputedTo('flat'); -expect('preserve-3d').parsesAs('preserve-3d').isComputedTo('preserve-3d'); +expect('visible').parsesAs('visible').isComputedTo('visible'); +expect('hidden').parsesAs('hidden').isComputedTo('hidden'); expect('none').isInvalid(); expect('0').isInvalid();
The CQ bit was checked by dstockwell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/200001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
The CQ bit was checked by dstockwell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/200001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by dstockwell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/200001
Message was sent while issue was closed.
Change committed as 170320 |