Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issue 211213002: CSS Transforms: Implement backface-visibility (Closed)

Created:
6 years, 9 months ago by dstockwell
Modified:
6 years, 9 months ago
Reviewers:
eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

CSS Transforms: Implement backface-visibility Implements backface-visibility as defined in CSS Transforms[1]. Behavior is identical to -webkit-backface-visibility. Note, this property is guarded by the CSSTransformsUnprefixed runtime feature (enabled only for testing). [1] http://www.w3.org/TR/css3-transforms/ NOTRY=true BUG=154772 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170320

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
A + LayoutTests/transforms/backface-visibility-parsing.html View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 43 (0 generated)
dstockwell
6 years, 9 months ago (2014-03-25 13:56:37 UTC) #1
eseidel
lgtm Where is it guarded?
6 years, 9 months ago (2014-03-25 14:07:38 UTC) #2
dstockwell
On 2014/03/25 14:07:38, eseidel wrote: > lgtm > > Where is it guarded? In https://codereview.chromium.org/211033002/ ...
6 years, 9 months ago (2014-03-25 14:29:06 UTC) #3
eseidel
Agreed. CSSPropertyNames.in is the new one used for generating a bunch of previously copy/paste code. ...
6 years, 9 months ago (2014-03-25 14:43:28 UTC) #4
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-26 04:37:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/80001
6 years, 9 months ago (2014-03-26 04:37:59 UTC) #6
commit-bot: I haz the power
Change committed as 170021
6 years, 9 months ago (2014-03-26 05:43:27 UTC) #7
vsevik
A revert of this CL has been created in https://codereview.chromium.org/212563007/ by vsevik@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-26 13:17:35 UTC) #8
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-27 11:55:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/180001
6 years, 9 months ago (2014-03-27 11:55:29 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 13:03:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 13:03:46 UTC) #12
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-27 13:06:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/180001
6 years, 9 months ago (2014-03-27 13:06:44 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:13:21 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 14:13:21 UTC) #16
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-27 14:38:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/180001
6 years, 9 months ago (2014-03-27 14:38:22 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:58:08 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 14:58:08 UTC) #20
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-27 15:00:48 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/180001
6 years, 9 months ago (2014-03-27 15:00:59 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 15:24:13 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 15:24:14 UTC) #24
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 9 months ago (2014-03-27 23:12:21 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/180001
6 years, 9 months ago (2014-03-27 23:12:29 UTC) #26
dstockwell
The CQ bit was unchecked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-27 23:34:25 UTC) #27
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 08:23:29 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/200001
6 years, 9 months ago (2014-03-28 08:23:38 UTC) #29
dstockwell
The CQ bit was unchecked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 08:23:39 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 08:23:45 UTC) #31
commit-bot: I haz the power
Failed to apply patch for LayoutTests/transforms/backface-visibility-parsing.html: While running svn copy LayoutTests/transforms/transform-style-parsing.html LayoutTests/transforms/backface-visibility-parsing.html --config-dir /b/commit-queue/subversion_config --non-interactive ...
6 years, 9 months ago (2014-03-28 08:23:46 UTC) #32
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 10:02:22 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/200001
6 years, 9 months ago (2014-03-28 10:02:26 UTC) #34
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 10:13:09 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-28 10:13:09 UTC) #36
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 10:14:37 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/200001
6 years, 9 months ago (2014-03-28 10:14:48 UTC) #38
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 11:10:15 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-28 11:10:16 UTC) #40
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 12:22:52 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211213002/200001
6 years, 9 months ago (2014-03-28 12:22:54 UTC) #42
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 12:23:17 UTC) #43
Message was sent while issue was closed.
Change committed as 170320

Powered by Google App Engine
This is Rietveld 408576698