Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: runtime/vm/scavenger.cc

Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling' (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address code review comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/redundancy_elimination.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/scavenger.cc
diff --git a/runtime/vm/scavenger.cc b/runtime/vm/scavenger.cc
index ba36ac8fc14adc940060e890107eb839e990c50b..d1bfd3fa1819143ae07f27adf217dc8da04a7022 100644
--- a/runtime/vm/scavenger.cc
+++ b/runtime/vm/scavenger.cc
@@ -15,7 +15,6 @@
#include "vm/store_buffer.h"
#include "vm/thread_registry.h"
#include "vm/timeline.h"
-#include "vm/verified_memory.h"
#include "vm/verifier.h"
#include "vm/visitor.h"
#include "vm/weak_table.h"
@@ -161,7 +160,6 @@ class ScavengerVisitor : public ObjectPointerVisitor {
memmove(reinterpret_cast<void*>(new_addr),
reinterpret_cast<void*>(raw_addr),
size);
- VerifiedMemory::Accept(new_addr, size);
// Remember forwarding address.
ForwardTo(raw_addr, new_addr);
}
@@ -170,7 +168,6 @@ class ScavengerVisitor : public ObjectPointerVisitor {
*p = new_obj;
// Update the store buffer as needed.
if (visiting_old_object_ != NULL) {
- VerifiedMemory::Accept(reinterpret_cast<uword>(p), sizeof(*p));
UpdateStoreBuffer(p, new_obj);
}
}
@@ -289,7 +286,7 @@ SemiSpace* SemiSpace::New(intptr_t size_in_words) {
return new SemiSpace(NULL);
} else {
intptr_t size_in_bytes = size_in_words << kWordSizeLog2;
- VirtualMemory* reserved = VerifiedMemory::Reserve(size_in_bytes);
+ VirtualMemory* reserved = VirtualMemory::Reserve(size_in_bytes);
if ((reserved == NULL) || !reserved->Commit(false)) { // Not executable.
// TODO(koda): If cache_ is not empty, we could try to delete it.
delete reserved;
@@ -297,7 +294,6 @@ SemiSpace* SemiSpace::New(intptr_t size_in_words) {
}
#if defined(DEBUG)
memset(reserved->address(), Heap::kZapByte, size_in_bytes);
- VerifiedMemory::Accept(reserved->start(), size_in_bytes);
#endif // defined(DEBUG)
return new SemiSpace(reserved);
}
@@ -309,7 +305,6 @@ void SemiSpace::Delete() {
if (reserved_ != NULL) {
const intptr_t size_in_bytes = size_in_words() << kWordSizeLog2;
memset(reserved_->address(), Heap::kZapByte, size_in_bytes);
- VerifiedMemory::Accept(reserved_->start(), size_in_bytes);
}
#endif
SemiSpace* old_cache = NULL;
@@ -429,7 +424,6 @@ void Scavenger::Epilogue(Isolate* isolate,
// objects candidates for promotion next time.
survivor_end_ = end_;
}
- VerifiedMemory::Accept(to_->start(), to_->end() - to_->start());
#if defined(DEBUG)
// We can only safely verify the store buffers from old space if there is no
// concurrent old space task. At the same time we prevent new tasks from
« no previous file with comments | « runtime/vm/redundancy_elimination.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698