chrome/browser/android/download/download_controller.cc - Issue 2111983002: Record one more reason that download is canceled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/download/download_controller.cc

Issue 2111983002: Record one more reason that download is canceled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/download/download_controller.cc

diff --git a/chrome/browser/android/download/download_controller.cc b/chrome/browser/android/download/download_controller.cc

index d7f594a86eb8d50b2bf7f21f32d39efe73cd905b..d6b1b034f305af1aef18333b3307e2f698f70436 100644

--- a/chrome/browser/android/download/download_controller.cc

+++ b/chrome/browser/android/download/download_controller.cc

@@ -424,8 +424,11 @@ void DownloadController::DangerousDownloadValidated(

DownloadItem* item = dlm->GetDownloadByGuid(download_guid);

if (!item)

return;

- if (accept)

+ if (accept) {

item->ValidateDangerousDownload();

- else

+ } else {

+ DownloadController::RecordDownloadCancelReason(

+ DownloadController::CANCEL_REASON_DANGEROUS_DOWNLOAD_INFOBAR_DISMISSED);

item->Remove();

+ }

}