Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: components/gcm_driver/registration_info.h

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push
Patch Set: address most of peter's concerns Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/registration_info.h
diff --git a/components/gcm_driver/registration_info.h b/components/gcm_driver/registration_info.h
index b9ba0a1b038c78f32ef11219796ef64f7eff4490..1ae7af4c11e5c27d3eef5256561a52fcd9897d3c 100644
--- a/components/gcm_driver/registration_info.h
+++ b/components/gcm_driver/registration_info.h
@@ -104,8 +104,14 @@ struct InstanceIDTokenInfo : public RegistrationInfo {
// E.g. for sending GCM messages, 'GCM' scope should be used.
std::string scope;
+ // Whether to send |app_id| to GCM as the "subtype" field (supported on all
+ // platforms) or as the "category" field (not supported on Android, since
+ // Google Play Services always sends the app package name as "category").
+ bool use_subtype;
+
// Allows including a small number of string key/value pairs that will be
- // associated with the token and may be used in processing the request.
+ // associated with the token and may be used in processing the request. These
+ // are not serialized/deserialized!
Peter Beverloo 2016/07/22 12:17:04 s/!/\./
johnme 2016/07/26 17:11:56 Done.
Peter Beverloo 2016/07/28 12:34:09 No you didn't?
johnme 2016/08/04 17:47:13 Blargh. Forgot to hit save :(
std::map<std::string, std::string> options;
};

Powered by Google App Engine
This is Rietveld 408576698