Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: components/gcm_driver/gcm_driver.h

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push
Patch Set: address most of peter's concerns Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver.h
diff --git a/components/gcm_driver/gcm_driver.h b/components/gcm_driver/gcm_driver.h
index 6cf0cdf3e20f442a64072a0167d1181fd47d97b6..6908f8c39ef1eb0944b8c5f45cbc4259e48eaa23 100644
--- a/components/gcm_driver/gcm_driver.h
+++ b/components/gcm_driver/gcm_driver.h
@@ -43,20 +43,22 @@ class InstanceIDHandler {
InstanceIDHandler();
virtual ~InstanceIDHandler();
- // Delete all tokens assoicated with |app_id|.
- void DeleteAllTokensForApp(const std::string& app_id,
- const DeleteTokenCallback& callback);
-
// Token service.
virtual void GetToken(const std::string& app_id,
+ bool use_subtype,
const std::string& authorized_entity,
const std::string& scope,
const std::map<std::string, std::string>& options,
const GetTokenCallback& callback) = 0;
virtual void DeleteToken(const std::string& app_id,
+ bool use_subtype,
const std::string& authorized_entity,
const std::string& scope,
const DeleteTokenCallback& callback) = 0;
+ // Delete all tokens assoicated with |app_id|.
Peter Beverloo 2016/07/22 12:17:03 nit: Delete comment, the name is clear enough.
johnme 2016/07/26 17:11:56 Done.
+ void DeleteAllTokensForApp(const std::string& app_id,
+ bool use_subtype,
+ const DeleteTokenCallback& callback);
// Persistence support.
virtual void AddInstanceIDData(const std::string& app_id,

Powered by Google App Engine
This is Rietveld 408576698