Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: components/gcm_driver/instance_id/instance_id_android.cc

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push
Patch Set: address most of peter's concerns Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/instance_id/instance_id_android.cc
diff --git a/components/gcm_driver/instance_id/instance_id_android.cc b/components/gcm_driver/instance_id/instance_id_android.cc
index c49cf41630936764fbf9413a19f9ed5002826edb..e6da3f4f2e55975ec2dfb54853b888da8fd0bdd5 100644
--- a/components/gcm_driver/instance_id/instance_id_android.cc
+++ b/components/gcm_driver/instance_id/instance_id_android.cc
@@ -45,8 +45,11 @@ bool InstanceIDAndroid::RegisterJni(JNIEnv* env) {
}
// static
-std::unique_ptr<InstanceID> InstanceID::Create(const std::string& app_id,
- gcm::GCMDriver* gcm_driver) {
+std::unique_ptr<InstanceID> InstanceID::CreateInternal(
+ const std::string& app_id,
+ bool use_subtype,
+ gcm::GCMDriver* gcm_driver) {
+ CHECK(use_subtype) << "Android only supports InstanceIDs using subtypes";
return base::WrapUnique(new InstanceIDAndroid(app_id, gcm_driver));
}

Powered by Google App Engine
This is Rietveld 408576698