components/gcm_driver/gcm_driver_desktop.h - Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_driver_desktop.h

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push

Patch Set: address most of peter's concerns Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/gcm_driver/gcm_driver.h ('K') | « components/gcm_driver/gcm_driver.cc ('k') | components/gcm_driver/gcm_driver_desktop.cc » ('j') | components/gcm_driver/registration_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_driver_desktop.h

diff --git a/components/gcm_driver/gcm_driver_desktop.h b/components/gcm_driver/gcm_driver_desktop.h

index 5a986e2102539b423f13e20c4d6de9d43d7e9407..bd4ad98ce30535352d4d85e6ae5acff1a69325f5 100644

--- a/components/gcm_driver/gcm_driver_desktop.h

+++ b/components/gcm_driver/gcm_driver_desktop.h

@@ -111,11 +111,13 @@ class GCMDriverDesktop : public GCMDriver,

// InstanceIDHandler implementation:

void GetToken(const std::string& app_id,

+ bool use_subtype,

const std::string& authorized_entity,

const std::string& scope,

const std::map<std::string, std::string>& options,

const GetTokenCallback& callback) override;

void DeleteToken(const std::string& app_id,

+ bool use_subtype,

const std::string& authorized_entity,

const std::string& scope,

const DeleteTokenCallback& callback) override;

@@ -152,10 +154,12 @@ class GCMDriverDesktop : public GCMDriver,

void DoRemoveInstanceIDData(const std::string& app_id);

void DoGetInstanceIDData(const std::string& app_id);

void DoGetToken(const std::string& app_id,

+ bool use_subtype,

const std::string& authorized_entity,

const std::string& scope,

const std::map<std::string, std::string>& options);

void DoDeleteToken(const std::string& app_id,

+ bool use_subtype,

const std::string& authorized_entity,

const std::string& scope);

« components/gcm_driver/gcm_driver.h ('K') | « components/gcm_driver/gcm_driver.cc ('k') | components/gcm_driver/gcm_driver_desktop.cc » ('j') | components/gcm_driver/registration_info.h » ('J')