Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: components/gcm_driver/gcm_desktop_utils.cc

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push
Patch Set: Remove channel from product_category_for_subtypes, and address nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/gcm_desktop_utils.h ('k') | components/gcm_driver/gcm_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_desktop_utils.cc
diff --git a/components/gcm_driver/gcm_desktop_utils.cc b/components/gcm_driver/gcm_desktop_utils.cc
index bf1210799e8a4ad83626f964a11a5815636b6866..7537195e316493ed8817a0e41eb273adb1ac34af 100644
--- a/components/gcm_driver/gcm_desktop_utils.cc
+++ b/components/gcm_driver/gcm_desktop_utils.cc
@@ -63,11 +63,15 @@ std::string GetVersion() {
return version_info::GetVersionNumber();
}
-GCMClient::ChromeBuildInfo GetChromeBuildInfo(version_info::Channel channel) {
+GCMClient::ChromeBuildInfo GetChromeBuildInfo(
+ version_info::Channel channel,
+ const std::string& product_category_for_subtypes) {
GCMClient::ChromeBuildInfo chrome_build_info;
chrome_build_info.platform = GetPlatform();
chrome_build_info.channel = GetChannel(channel);
chrome_build_info.version = GetVersion();
+ chrome_build_info.product_category_for_subtypes =
+ product_category_for_subtypes;
return chrome_build_info;
}
@@ -92,11 +96,13 @@ std::unique_ptr<GCMDriver> CreateGCMDriverDesktop(
const base::FilePath& store_path,
const scoped_refptr<net::URLRequestContextGetter>& request_context,
version_info::Channel channel,
+ const std::string& product_category_for_subtypes,
const scoped_refptr<base::SequencedTaskRunner>& ui_task_runner,
const scoped_refptr<base::SequencedTaskRunner>& io_task_runner,
const scoped_refptr<base::SequencedTaskRunner>& blocking_task_runner) {
return std::unique_ptr<GCMDriver>(new GCMDriverDesktop(
- std::move(gcm_client_factory), GetChromeBuildInfo(channel),
+ std::move(gcm_client_factory),
+ GetChromeBuildInfo(channel, product_category_for_subtypes),
GetChannelStatusRequestUrl(channel), GetUserAgent(channel), prefs,
store_path, request_context, ui_task_runner, io_task_runner,
blocking_task_runner));
« no previous file with comments | « components/gcm_driver/gcm_desktop_utils.h ('k') | components/gcm_driver/gcm_driver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698