components/gcm_driver/gcm_desktop_utils.h - Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_desktop_utils.h

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push

Patch Set: Remove channel from product_category_for_subtypes, and address nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver/gcm_desktop_utils.h

diff --git a/components/gcm_driver/gcm_desktop_utils.h b/components/gcm_driver/gcm_desktop_utils.h

index bd8ce48ca3fcdd17ef137a1fa4a78cb221cb5c69..8441a3f5c4ded64d441fcd95ea42fb225efe35b7 100644

--- a/components/gcm_driver/gcm_desktop_utils.h

+++ b/components/gcm_driver/gcm_desktop_utils.h

@@ -31,6 +31,7 @@ std::unique_ptr<GCMDriver> CreateGCMDriverDesktop(

const base::FilePath& store_path,

const scoped_refptr<net::URLRequestContextGetter>& request_context,

version_info::Channel channel,

+ const std::string& product_category_for_subtypes,

const scoped_refptr<base::SequencedTaskRunner>& ui_task_runner,

const scoped_refptr<base::SequencedTaskRunner>& io_task_runner,

const scoped_refptr<base::SequencedTaskRunner>& blocking_task_runner);

« no previous file with comments | « components/gcm_driver/gcm_client_impl_unittest.cc ('k') | components/gcm_driver/gcm_desktop_utils.cc » ('j') | no next file with comments »