components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc - Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push

Patch Set: Address jianli's review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/gcm_driver/gcm_client_impl.h ('K') | « components/gcm_driver/instance_id/BUILD.gn ('k') | components/gcm_driver/instance_id/instance_id.h » ('j') | google_apis/gcm/engine/gcm_request_test_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc

diff --git a/components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc b/components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc

index 0ee7f0b6320f07f2dafc1f3e97a0102ddd48b5cc..2c328ddd8d806d18976eb202cc8f77e4af9a4d3c 100644

--- a/components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc

+++ b/components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc

@@ -57,9 +57,9 @@ void FakeGCMDriverForInstanceID::GetToken(

const std::string& scope,

const std::map<std::string, std::string>& options,

const GetTokenCallback& callback) {

- std::string token;

std::string key = app_id + authorized_entity + scope;

auto iter = tokens_.find(key);

+ std::string token;

if (iter != tokens_.end()) {

token = iter->second;

} else {