Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: components/gcm_driver/instance_id/instance_id_driver.cc

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push
Patch Set: Fix thestig nits and Chrome OS compile Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/instance_id/instance_id_driver.cc
diff --git a/components/gcm_driver/instance_id/instance_id_driver.cc b/components/gcm_driver/instance_id/instance_id_driver.cc
index 3cd96b70091ec8e1a8da4c828ab11d99754eca16..1d33269c03629bcd0ca951eb53e3fe31368c7e9d 100644
--- a/components/gcm_driver/instance_id/instance_id_driver.cc
+++ b/components/gcm_driver/instance_id/instance_id_driver.cc
@@ -33,12 +33,22 @@ InstanceIDDriver::~InstanceIDDriver() {
}
InstanceID* InstanceIDDriver::GetInstanceID(const std::string& app_id) {
+ return GetInstanceID(app_id, true /* use_subtype */);
+}
+
+InstanceID* InstanceIDDriver::GetInstanceIDForExtensions(
+ const std::string& app_id) {
+ return GetInstanceID(app_id, false /* use_subtype */);
+}
+
+InstanceID* InstanceIDDriver::GetInstanceID(const std::string& app_id,
+ bool use_subtype) {
auto iter = instance_id_map_.find(app_id);
if (iter != instance_id_map_.end())
return iter->second.get();
std::unique_ptr<InstanceID> instance_id =
- InstanceID::Create(app_id, gcm_driver_);
+ InstanceID::CreateInternal(app_id, use_subtype, gcm_driver_);
InstanceID* instance_id_ptr = instance_id.get();
instance_id_map_.insert(std::make_pair(app_id, std::move(instance_id)));
return instance_id_ptr;

Powered by Google App Engine
This is Rietveld 408576698