Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: components/gcm_driver/gcm_profile_service.h

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push
Patch Set: Fix thestig nits and Chrome OS compile Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_profile_service.h
diff --git a/components/gcm_driver/gcm_profile_service.h b/components/gcm_driver/gcm_profile_service.h
index 84bd2742bab5a9a43ff751db9ee53172408fdba2..9094a08d13761ab9961e983a4d1e6a2ef5282f53 100644
--- a/components/gcm_driver/gcm_profile_service.h
+++ b/components/gcm_driver/gcm_profile_service.h
@@ -56,6 +56,7 @@ class GCMProfileService : public KeyedService {
base::FilePath path,
net::URLRequestContextGetter* request_context,
version_info::Channel channel,
+ const std::string& product_category_for_subtypes,
jianli 2016/08/08 22:11:51 The name |product_category_for_subtypes| is not ea
johnme 2016/08/10 13:09:55 See reply above. gcm_category would be confusing,
std::unique_ptr<ProfileIdentityProvider> identity_provider,
std::unique_ptr<GCMClientFactory> gcm_client_factory,
const scoped_refptr<base::SequencedTaskRunner>& ui_task_runner,

Powered by Google App Engine
This is Rietveld 408576698