Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: components/gcm_driver/gcm_driver_desktop_unittest.cc

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push
Patch Set: Fix thestig nits and Chrome OS compile Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver_desktop_unittest.cc
diff --git a/components/gcm_driver/gcm_driver_desktop_unittest.cc b/components/gcm_driver/gcm_driver_desktop_unittest.cc
index a033d7aa3606c7db13600b86e4c8b1bf36ca679f..bba13c32c7ddc9d15914625cacf67c7abd8eceba 100644
--- a/components/gcm_driver/gcm_driver_desktop_unittest.cc
+++ b/components/gcm_driver/gcm_driver_desktop_unittest.cc
@@ -238,10 +238,12 @@ FakeGCMClient* GCMDriverTest::GetGCMClient() {
void GCMDriverTest::CreateDriver() {
scoped_refptr<net::URLRequestContextGetter> request_context =
new net::TestURLRequestContextGetter(io_thread_.task_runner());
+ GCMClient::ChromeBuildInfo chrome_build_info;
+ chrome_build_info.product_category_for_subtypes = "com.chrome.stable.macosx";
driver_.reset(new GCMDriverDesktop(
std::unique_ptr<GCMClientFactory>(new FakeGCMClientFactory(
base::ThreadTaskRunnerHandle::Get(), io_thread_.task_runner())),
- GCMClient::ChromeBuildInfo(), "http://channel.status.request.url",
+ chrome_build_info, "http://channel.status.request.url",
"user-agent-string", &prefs_, temp_dir_.path(), request_context,
base::ThreadTaskRunnerHandle::Get(), io_thread_.task_runner(),
message_loop_.task_runner()));
@@ -1226,7 +1228,7 @@ void GCMDriverInstanceIDTest::GetToken(const std::string& app_id,
set_async_operation_completed_callback(run_loop.QuitClosure());
std::map<std::string, std::string> options;
driver()->GetInstanceIDHandlerInternal()->GetToken(
- app_id, authorized_entity, scope, options,
+ app_id, false /* use_subtype */, authorized_entity, scope, options,
base::Bind(&GCMDriverTest::RegisterCompleted, base::Unretained(this)));
if (wait_to_finish == WAIT)
run_loop.Run();
@@ -1239,7 +1241,7 @@ void GCMDriverInstanceIDTest::DeleteToken(const std::string& app_id,
base::RunLoop run_loop;
set_async_operation_completed_callback(run_loop.QuitClosure());
driver()->GetInstanceIDHandlerInternal()->DeleteToken(
- app_id, authorized_entity, scope,
+ app_id, false /* use_subtype */, authorized_entity, scope,
base::Bind(&GCMDriverTest::UnregisterCompleted, base::Unretained(this)));
if (wait_to_finish == WAIT)
run_loop.Run();

Powered by Google App Engine
This is Rietveld 408576698