appengine/chromium_cq_status/makefile - Issue 2111713004: Teach CQ status app to check login status of users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/chromium_cq_status/makefile

Issue 2111713004: Teach CQ status app to check login status of users. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: cleanup Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/chromium_cq_status/makefile

diff --git a/appengine/chromium_cq_status/makefile b/appengine/chromium_cq_status/makefile

index 5f6b41f4e0eadf125bc95db6d6e9efec29b71446..ef2360cded51a05a69d39d5eb8a36f50c7f54354 100644

--- a/appengine/chromium_cq_status/makefile

+++ b/appengine/chromium_cq_status/makefile

@@ -2,6 +2,7 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

+APP_ID ?= chromium-cq-status

Sergiy Byelozyorov 2016/07/01 17:13:06 why ?=

tandrii(chromium) 2016/07/01 18:56:55 this means set only if not set before. This allows

NPM_VERSION := $(shell npm --version 2>/dev/null)

BOWER_VERSION := $(shell bower --version 2>/dev/null)

GIT_REVISION := $(shell git rev-parse --short HEAD)

@@ -22,6 +23,7 @@ single-test: check

./node_modules/karma/bin/karma start --single-run

deploy:

- appcfg.py --oauth2 update app.yaml highend.yaml --version `git rev-parse --short HEAD`

+ appcfg.py --oauth2 update app.yaml highend.yaml --version `git rev-parse --short HEAD` -A $(APP_ID)

+ # appcfg.py -A $(APP_ID) update_dispatch --version `git rev-parse --short HEAD`

Sergiy Byelozyorov 2016/07/01 17:13:06 looks like debug line to me... remove or uncomment

tandrii(chromium) 2016/07/01 18:56:55 not debug, wrote separately.

.PHONY: check test single-test