Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: components/offline_pages/client_policy_controller.cc

Issue 2111653002: [Offline Pages] Adding metadatas for namespace async_loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/client_policy_controller.cc
diff --git a/components/offline_pages/client_policy_controller.cc b/components/offline_pages/client_policy_controller.cc
index 0d1e114d41ca631b7bb291d65aaa313e27f60401..dd4785b5279d990990651524b98f6f2d280d0885 100644
--- a/components/offline_pages/client_policy_controller.cc
+++ b/components/offline_pages/client_policy_controller.cc
@@ -24,6 +24,10 @@ ClientPolicyController::ClientPolicyController() {
kLastNNamespace,
MakePolicy(kLastNNamespace, LifetimeType::TEMPORARY,
base::TimeDelta::FromDays(2), kUnlimitedPages, 1)));
+ policies_.insert(std::make_pair(
+ kAsyncNamespace, MakePolicy(kAsyncNamespace, LifetimeType::TEMPORARY,
fgorski 2016/07/01 19:26:09 They should be LifetimeType::PERSISTENT.
romax 2016/07/06 22:03:28 I'm not against to change it to persistent. Howeve
fgorski 2016/07/07 17:01:45 We are not done with the feature. Downloads home i
+ base::TimeDelta::FromDays(2), kUnlimitedPages,
fgorski 2016/07/01 19:26:09 We need to make sure we have an infinite expiratio
romax 2016/07/06 22:03:27 please see previous comment.
+ kUnlimitedPages)));
// Fallback policy.
policies_.insert(std::make_pair(
kDefaultNamespace, MakePolicy(kDefaultNamespace, LifetimeType::TEMPORARY,
« no previous file with comments | « components/offline_pages/client_namespace_constants.cc ('k') | components/offline_pages/client_policy_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698