[Offline Pages] Adding metadatas for namespace async_loading.

components/offline_pages/client_policy_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/client_policy_controller.h"
 
 #include <utility>
 
 #include "base/time/time.h"
 #include "components/offline_pages/client_namespace_constants.h"
 
 using LifetimeType = offline_pages::LifetimePolicy::LifetimeType;
 
 namespace offline_pages {
 
 ClientPolicyController::ClientPolicyController() {
   policies_.clear();
   // Manually defining client policies for bookmark and last_n.
   policies_.insert(std::make_pair(
       kBookmarkNamespace,
       MakePolicy(kBookmarkNamespace, LifetimeType::TEMPORARY,
                  base::TimeDelta::FromDays(7), kUnlimitedPages, 1)));
   policies_.insert(std::make_pair(
       kLastNNamespace,
       MakePolicy(kLastNNamespace, LifetimeType::TEMPORARY,
                  base::TimeDelta::FromDays(2), kUnlimitedPages, 1)));
+  policies_.insert(std::make_pair(
+      kAsyncNamespace, MakePolicy(kAsyncNamespace, LifetimeType::TEMPORARY,

[fgorski, 2016/07/01 19:26:09]

They should be LifetimeType::PERSISTENT.

[romax, 2016/07/06 22:03:28]

I'm not against to change it to persistent. However I don't see us having a
mechanism to delete persistent pages now. It means if we mark it as persistent
and make it have an infinite expiration_period (which is a good thing to do),
there's no way to delete them unless wipe all pages. So I'm not sure if I should
do this and add a check when expiring pages *for now*. Also please let me know
if we have something for user to delete persistent pages, if there is one, I'm
more than happy to finish the changes.

[fgorski, 2016/07/07 17:01:45]

We are not done with the feature. Downloads home is where we will be able to
delete the pages from. I believe it should already be doable from then clear
browsing data (or similar settings page).
Also, for development you can do it from chrome://offline-internals.

+                                  base::TimeDelta::FromDays(2), kUnlimitedPages,

[fgorski, 2016/07/01 19:26:09]

We need to make sure we have an infinite expiration_period.
Unless we ignore it already for persistent lifetime.

[romax, 2016/07/06 22:03:27]

please see previous comment.

+                                  kUnlimitedPages)));
   // Fallback policy.
   policies_.insert(std::make_pair(
       kDefaultNamespace, MakePolicy(kDefaultNamespace, LifetimeType::TEMPORARY,
                                     base::TimeDelta::FromDays(1), 10, 1)));
 }
 
 ClientPolicyController::~ClientPolicyController() {}
 
 // static
 const OfflinePageClientPolicy ClientPolicyController::MakePolicy(
@@ skipping 11 matching lines @@
 const OfflinePageClientPolicy& ClientPolicyController::GetPolicy(
     const std::string& name_space) const {
   const auto& iter = policies_.find(name_space);
   if (iter != policies_.end())
     return iter->second;
   // Fallback when the namespace isn't defined.
   return policies_.at(kDefaultNamespace);
 }
 
 }  // namespace offline_pages