Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2111643002: Update containing block's positioned descendants list when an object becomes out-of-flow-positioned (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Update containing block's positioned descendants list when an object becomes out-of-flow-positioned This is required when there are descendants needing overflow recalc. Otherwise during overflow recalc because the containing block's positioned descendant list didn't contain the new out-of-flow-positioned object we would not reach the descendants needing overflow recalc. BUG=623867 TEST=fast/overflow/add-visual-overflow-and-change-container-position.html Review-Url: https://codereview.chromium.org/2103843003 Cr-Commit-Position: refs/heads/master@{#402550} Committed: https://chromium.googlesource.com/chromium/src/+/ea9c8c0ffffe09bb297ed9c5c619f411e06f7250

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/overflow/add-visual-overflow-and-change-container-position.html View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/overflow/add-visual-overflow-and-change-container-position-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Xianzhu
Committed patchset #1 (id:1) manually as ea9c8c0ffffe09bb297ed9c5c619f411e06f7250.
4 years, 5 months ago (2016-06-29 20:56:04 UTC) #2
Charlie Reis
4 years, 5 months ago (2016-06-29 22:29:50 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2109263002/ by creis@chromium.org.

The reason for reverting is: Caused a compile error in the M52 build.  See
https://crbug.com/624571 for details..

Powered by Google App Engine
This is Rietveld 408576698