Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 2103843003: Update containing block's positioned descendants list when an object becomes out-of-flow-positioned (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
Reviewers:
eae, trchen
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update containing block's positioned descendants list when an object becomes out-of-flow-positioned This is required when there are descendants needing overflow recalc. Otherwise during overflow recalc because the containing block's positioned descendant list didn't contain the new out-of-flow-positioned object we would not reach the descendants needing overflow recalc. BUG=623867 TEST=fast/overflow/add-visual-overflow-and-change-container-position.html Committed: https://crrev.com/fd08a658d68598dce7886abf88fbc71ed6659f41 Cr-Commit-Position: refs/heads/master@{#402550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/overflow/add-visual-overflow-and-change-container-position.html View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/overflow/add-visual-overflow-and-change-container-position-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Xianzhu
4 years, 5 months ago (2016-06-28 17:41:24 UTC) #2
eae
OK, LGTM
4 years, 5 months ago (2016-06-28 17:48:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103843003/1
4 years, 5 months ago (2016-06-28 19:57:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/236980)
4 years, 5 months ago (2016-06-28 20:08:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103843003/1
4 years, 5 months ago (2016-06-28 20:28:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 21:37:28 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fd08a658d68598dce7886abf88fbc71ed6659f41 Cr-Commit-Position: refs/heads/master@{#402550}
4 years, 5 months ago (2016-06-28 21:39:29 UTC) #14
Xianzhu
4 years, 5 months ago (2016-06-28 21:46:40 UTC) #15
Message was sent while issue was closed.
Sorry the bug number was wrong. It should be 622655.

Powered by Google App Engine
This is Rietveld 408576698