infra/services/sysmon/puppet_metrics.py - Issue 2111473003: Issue 623854: Support unit annotations in ts_mon metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/services/sysmon/puppet_metrics.py

Issue 2111473003: Issue 623854: Support unit annotations in ts_mon metrics (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Split off go changes to a separate CL: https://codereview.chromium.org/2125943003 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: infra/services/sysmon/puppet_metrics.py

diff --git a/infra/services/sysmon/puppet_metrics.py b/infra/services/sysmon/puppet_metrics.py

index c6e41e870392e1df1efb4d89f4bc54c3922aaed3..5c4ac963fd17ccf4d64136b34fccb6f2affecefd 100644

--- a/infra/services/sysmon/puppet_metrics.py

+++ b/infra/services/sysmon/puppet_metrics.py

@@ -28,8 +28,11 @@ resources = ts_mon.GaugeMetric('puppet/resources',

description='Number of resources known by the puppet client in its last '

'run')

times = ts_mon.FloatMetric('puppet/times',

- description='Time taken to perform various parts of the last puppet run')

-age = ts_mon.FloatMetric('puppet/age', description='Time since last run')

+ description='Time taken to perform various parts of the last puppet run',

+ units=ts_mon.MetricsDataUnits.SECONDS)

+age = ts_mon.FloatMetric('puppet/age',

+ description='Time since last run',

+ units=ts_mon.MetricsDataUnits.SECONDS)

def _lastrunfile(): # pragma: no cover

« no previous file with comments | « infra/services/sysmon/android_device_metrics.py ('k') | infra/services/sysmon/system_metrics.py » ('j') | no next file with comments »