infra/services/sysmon/android_device_metrics.py - Issue 2111473003: Issue 623854: Support unit annotations in ts_mon metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/services/sysmon/android_device_metrics.py

Issue 2111473003: Issue 623854: Support unit annotations in ts_mon metrics (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Split off go changes to a separate CL: https://codereview.chromium.org/2125943003 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: infra/services/sysmon/android_device_metrics.py

diff --git a/infra/services/sysmon/android_device_metrics.py b/infra/services/sysmon/android_device_metrics.py

index 3432167b59358f4d9d364c5278a4c37e22300b99..96f5e787425f10512e2bad5a184953f5baa59ec3 100644

--- a/infra/services/sysmon/android_device_metrics.py

+++ b/infra/services/sysmon/android_device_metrics.py

@@ -40,13 +40,16 @@ dev_type = ts_mon.StringMetric('dev/mobile/type',

dev_os = ts_mon.StringMetric('dev/mobile/os',

description='operating system of the device')

dev_uptime = ts_mon.FloatMetric('dev/mobile/uptime',

- description='device uptime in seconds')

+ description='device uptime in seconds',

+ units=ts_mon.MetricsDataUnits.SECONDS)

mem_free = ts_mon.GaugeMetric(

'dev/mobile/mem/free',

- description='available memory (free + cached + buffers) in kb')

+ description='available memory (free + cached + buffers) in kb',

+ units=ts_mon.MetricsDataUnits.KIBIBYTES)

mem_total = ts_mon.GaugeMetric(

'dev/mobile/mem/total',

- description='total memory (device ram - kernel leaks) in kb')

+ description='total memory (device ram - kernel leaks) in kb',

+ units=ts_mon.MetricsDataUnits.KIBIBYTES)

proc_count = ts_mon.GaugeMetric('dev/mobile/proc/count',

description='process count')

« no previous file with comments | « no previous file | infra/services/sysmon/puppet_metrics.py » ('j') | no next file with comments »