Reland of Link to DirectWrite directly, instead of calling LoadLibrary

Reland of Link to DirectWrite directly, instead of calling LoadLibrary (patchset #1 id:1 of https://codereview.chromium.org/2117683002/ )

Reason for revert:
Attempting to reland original change.

Original issue's description:
> Revert of Link to DirectWrite directly, instead of calling LoadLibrary (patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ )
>
> Reason for revert:
> Breaks aura_demo target
>
> Original issue's description:
> > Link to DirectWrite directly, instead of calling LoadLibrary
> >
> > BUG=
> >
> > Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07
> > Cr-Commit-Position: refs/heads/master@{#403344}
>
> TBR=scottmg@chromium.org,jam@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://crrev.com/d825ab07a72e8440c0d1b77464eef5d8740a7258
> Cr-Commit-Position: refs/heads/master@{#403379}

BUG=
TBR=jam@chromium.org

Committed: https://crrev.com/ceb58c4b801e325292f37d3a60b9378ac92a6955
Cr-Commit-Position: refs/heads/master@{#404268}

[Ilya Kulshin, 2016-07-01 01:09:45]

Created Reland of Link to DirectWrite directly, instead of calling LoadLibrary

[Ilya Kulshin, 2016-07-01 01:10:22]

Description was changed from

==========
Reland of Link to DirectWrite directly, instead of calling LoadLibrary (patchset
#1 id:1 of https://codereview.chromium.org/2117683002/ )

Reason for revert:
Attempting to reland original change.

Original issue's description:
> Revert of Link to DirectWrite directly, instead of calling LoadLibrary
(patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ )
> 
> Reason for revert:
> Breaks aura_demo target
> 
> Original issue's description:
> > Link to DirectWrite directly, instead of calling LoadLibrary
> >
> > BUG=
> >
> > Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07
> > Cr-Commit-Position: refs/heads/master@{#403344}
> 
> TBR=scottmg@chromium.org,jam@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
> 
> Committed: https://crrev.com/d825ab07a72e8440c0d1b77464eef5d8740a7258
> Cr-Commit-Position: refs/heads/master@{#403379}

TBR=scottmg@chromium.org,jam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
==========

to

==========
Reland of Link to DirectWrite directly, instead of calling LoadLibrary (patchset
#1 id:1 of https://codereview.chromium.org/2117683002/ )

Reason for revert:
Attempting to reland original change.

Original issue's description:
> Revert of Link to DirectWrite directly, instead of calling LoadLibrary
(patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ )
> 
> Reason for revert:
> Breaks aura_demo target
> 
> Original issue's description:
> > Link to DirectWrite directly, instead of calling LoadLibrary
> >
> > BUG=
> >
> > Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07
> > Cr-Commit-Position: refs/heads/master@{#403344}
> 
> TBR=scottmg@chromium.org,jam@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
> 
> Committed: https://crrev.com/d825ab07a72e8440c0d1b77464eef5d8740a7258
> Cr-Commit-Position: refs/heads/master@{#403379}

BUG=
==========

[Ilya Kulshin, 2016-07-01 01:10:55]

Apologies for spam, this isn't ready yet.

On Thu, Jun 30, 2016 at 6:09 PM, <kulshin@chromium.org> wrote:

> Reviewers: scottmg, jam
> CL: https://codereview.chromium.org/2111373002/
>
> Message:
> Created Reland of Link to DirectWrite directly, instead of calling
> LoadLibrary
>
> Description:
> Reland of Link to DirectWrite directly, instead of calling LoadLibrary
> (patchset
> #1 id:1 of https://codereview.chromium.org/2117683002/ )
>
> Reason for revert:
> Attempting to reland original change.
>
> Original issue's description:
> > Revert of Link to DirectWrite directly, instead of calling LoadLibrary
> (patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ )
> >
> > Reason for revert:
> > Breaks aura_demo target
> >
> > Original issue's description:
> > > Link to DirectWrite directly, instead of calling LoadLibrary
> > >
> > > BUG=
> > >
> > > Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07
> > > Cr-Commit-Position: refs/heads/master@{#403344}
> >
> > TBR=scottmg@chromium.org,jam@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=
> >
> > Committed: https://crrev.com/d825ab07a72e8440c0d1b77464eef5d8740a7258
> > Cr-Commit-Position: refs/heads/master@{#403379}
>
> TBR=scottmg@chromium.org,jam@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+48, -103 lines):
> M content/child/BUILD.gn
> M content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc
> M content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc
> M content/child/dwrite_font_proxy/font_fallback_win_unittest.cc
> M content/content_child.gypi
> M content/content_tests.gypi
> M content/test/BUILD.gn
> M ui/gfx/BUILD.gn
> M ui/gfx/font_fallback_win.cc
> M ui/gfx/gfx.gyp
> M ui/gfx/gfx_tests.gyp
> M ui/gfx/win/direct_write.cc
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ilya Kulshin, 2016-07-01 19:04:28]

Patchset #2 (id:230001) has been deleted

[Ilya Kulshin, 2016-07-01 19:05:47]

ptal

The only actual change since the revert is in ui/aura/aura.gyp. The changes in
content/child/dwrite_font_proxy/* are the result of running "git cl format".

[scottmg, 2016-07-01 19:19:02]

https://codereview.chromium.org/2111373002/diff/270001/ui/aura/aura.gyp
File ui/aura/aura.gyp (right):

https://codereview.chromium.org/2111373002/diff/270001/ui/aura/aura.gyp#newco...
ui/aura/aura.gyp:246: ['OS=="win"', {
I feel like this should be depending on ui/gfx or whatever uses dwrite, rather
than linking the lib itself?

[Ilya Kulshin, 2016-07-01 19:46:39]

https://codereview.chromium.org/2111373002/diff/270001/ui/aura/aura.gyp
File ui/aura/aura.gyp (right):

https://codereview.chromium.org/2111373002/diff/270001/ui/aura/aura.gyp#newco...
ui/aura/aura.gyp:246: ['OS=="win"', {
On 2016/07/01 19:19:02, scottmg (OOO until August) wrote:
> I feel like this should be depending on ui/gfx or whatever uses dwrite, rather
> than linking the lib itself?

Unless I'm misunderstanding the gyp, it looks like this already has a dependency
on gfx (line 229), which links dwrite.lib. Do we expect our build system to pull
in that dependency to the parent?

[scottmg, 2016-07-01 19:52:49]

Oh, I didn't notice gfx is a component. OK, not worth fiddling with an export of
the dependency so lgtm.

[Ilya Kulshin, 2016-07-06 17:19:25]

The CQ bit was checked by kulshin@chromium.org

[commit-bot: I haz the power, 2016-07-06 17:19:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 17:27:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 17:27:42]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ilya Kulshin, 2016-07-07 23:23:36]

Description was changed from

==========
Reland of Link to DirectWrite directly, instead of calling LoadLibrary (patchset
#1 id:1 of https://codereview.chromium.org/2117683002/ )

Reason for revert:
Attempting to reland original change.

Original issue's description:
> Revert of Link to DirectWrite directly, instead of calling LoadLibrary
(patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ )
> 
> Reason for revert:
> Breaks aura_demo target
> 
> Original issue's description:
> > Link to DirectWrite directly, instead of calling LoadLibrary
> >
> > BUG=
> >
> > Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07
> > Cr-Commit-Position: refs/heads/master@{#403344}
> 
> TBR=scottmg@chromium.org,jam@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
> 
> Committed: https://crrev.com/d825ab07a72e8440c0d1b77464eef5d8740a7258
> Cr-Commit-Position: refs/heads/master@{#403379}

BUG=
==========

to

==========
Reland of Link to DirectWrite directly, instead of calling LoadLibrary (patchset
#1 id:1 of https://codereview.chromium.org/2117683002/ )

Reason for revert:
Attempting to reland original change.

Original issue's description:
> Revert of Link to DirectWrite directly, instead of calling LoadLibrary
(patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ )
> 
> Reason for revert:
> Breaks aura_demo target
> 
> Original issue's description:
> > Link to DirectWrite directly, instead of calling LoadLibrary
> >
> > BUG=
> >
> > Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07
> > Cr-Commit-Position: refs/heads/master@{#403344}
> 
> TBR=scottmg@chromium.org,jam@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
> 
> Committed: https://crrev.com/d825ab07a72e8440c0d1b77464eef5d8740a7258
> Cr-Commit-Position: refs/heads/master@{#403379}

BUG=
TBR=jam@chromium.org
==========

[Ilya Kulshin, 2016-07-07 23:23:44]

The CQ bit was checked by kulshin@chromium.org

[Ilya Kulshin, 2016-07-07 23:23:45]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2111373002/#ps290001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-07 23:24:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 23:39:15]

Description was changed from

==========
Reland of Link to DirectWrite directly, instead of calling LoadLibrary (patchset
#1 id:1 of https://codereview.chromium.org/2117683002/ )

Reason for revert:
Attempting to reland original change.

Original issue's description:
> Revert of Link to DirectWrite directly, instead of calling LoadLibrary
(patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ )
> 
> Reason for revert:
> Breaks aura_demo target
> 
> Original issue's description:
> > Link to DirectWrite directly, instead of calling LoadLibrary
> >
> > BUG=
> >
> > Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07
> > Cr-Commit-Position: refs/heads/master@{#403344}
> 
> TBR=scottmg@chromium.org,jam@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
> 
> Committed: https://crrev.com/d825ab07a72e8440c0d1b77464eef5d8740a7258
> Cr-Commit-Position: refs/heads/master@{#403379}

BUG=
TBR=jam@chromium.org
==========

to

==========
Reland of Link to DirectWrite directly, instead of calling LoadLibrary (patchset
#1 id:1 of https://codereview.chromium.org/2117683002/ )

Reason for revert:
Attempting to reland original change.

Original issue's description:
> Revert of Link to DirectWrite directly, instead of calling LoadLibrary
(patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ )
> 
> Reason for revert:
> Breaks aura_demo target
> 
> Original issue's description:
> > Link to DirectWrite directly, instead of calling LoadLibrary
> >
> > BUG=
> >
> > Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07
> > Cr-Commit-Position: refs/heads/master@{#403344}
> 
> TBR=scottmg@chromium.org,jam@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
> 
> Committed: https://crrev.com/d825ab07a72e8440c0d1b77464eef5d8740a7258
> Cr-Commit-Position: refs/heads/master@{#403379}

BUG=
TBR=jam@chromium.org
==========

[commit-bot: I haz the power, 2016-07-07 23:39:16]

Committed patchset #4 (id:290001)

[commit-bot: I haz the power, 2016-07-07 23:39:28]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 23:41:01]

Description was changed from

==========
Reland of Link to DirectWrite directly, instead of calling LoadLibrary (patchset
#1 id:1 of https://codereview.chromium.org/2117683002/ )

Reason for revert:
Attempting to reland original change.

Original issue's description:
> Revert of Link to DirectWrite directly, instead of calling LoadLibrary
(patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ )
> 
> Reason for revert:
> Breaks aura_demo target
> 
> Original issue's description:
> > Link to DirectWrite directly, instead of calling LoadLibrary
> >
> > BUG=
> >
> > Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07
> > Cr-Commit-Position: refs/heads/master@{#403344}
> 
> TBR=scottmg@chromium.org,jam@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
> 
> Committed: https://crrev.com/d825ab07a72e8440c0d1b77464eef5d8740a7258
> Cr-Commit-Position: refs/heads/master@{#403379}

BUG=
TBR=jam@chromium.org
==========

to

==========
Reland of Link to DirectWrite directly, instead of calling LoadLibrary (patchset
#1 id:1 of https://codereview.chromium.org/2117683002/ )

Reason for revert:
Attempting to reland original change.

Original issue's description:
> Revert of Link to DirectWrite directly, instead of calling LoadLibrary
(patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ )
>
> Reason for revert:
> Breaks aura_demo target
>
> Original issue's description:
> > Link to DirectWrite directly, instead of calling LoadLibrary
> >
> > BUG=
> >
> > Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07
> > Cr-Commit-Position: refs/heads/master@{#403344}
>
> TBR=scottmg@chromium.org,jam@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://crrev.com/d825ab07a72e8440c0d1b77464eef5d8740a7258
> Cr-Commit-Position: refs/heads/master@{#403379}

BUG=
TBR=jam@chromium.org

Committed: https://crrev.com/ceb58c4b801e325292f37d3a60b9378ac92a6955
Cr-Commit-Position: refs/heads/master@{#404268}
==========

[commit-bot: I haz the power, 2016-07-07 23:41:02]

Patchset 4 (id:??) landed as
https://crrev.com/ceb58c4b801e325292f37d3a60b9378ac92a6955
Cr-Commit-Position: refs/heads/master@{#404268}

[Ilya Kulshin, 2016-07-08 00:36:59]

A revert of this CL (patchset #4 id:290001) has been created in
https://codereview.chromium.org/2127313002/ by kulshin@chromium.org.

The reason for reverting is: Breaks
https://build.chromium.org/p/chromium.win/builders/Win8%20GYP/builds/430.