platform_tools/barelinux/bin/arm64_make script

platform_tools/barelinux/bin/arm64_make script

Motivation: an upcoming CL will change the Gyp variables.
That CL can change this script and the deps roll bot will
pick up those changes.
NOTRY=true

Committed: http://code.google.com/p/skia/source/detail?r=13937

[hal.canary, 2014-03-25 13:32:29]

Eric, PTAL.

I'll change the buildbot to use this script after this lands.

[borenet, 2014-03-25 13:38:54]

https://codereview.chromium.org/211133002/diff/30001/platform_tools/barelinux...
File platform_tools/barelinux/bin/arm64_make (right):

https://codereview.chromium.org/211133002/diff/30001/platform_tools/barelinux...
platform_tools/barelinux/bin/arm64_make:32: BUILD_TYPE='Debug'
We support the following in our "make" builds:

$ make tests BUILDTYPE=Debug

Does it make sense to support a similar syntax here?  Or rename the variable to
match and only overwrite it if it's not already defined?  That way, we could do
something like:

$ BUILDTYPE=Debug arm64_make tests

https://codereview.chromium.org/211133002/diff/30001/platform_tools/barelinux...
platform_tools/barelinux/bin/arm64_make:53: arm_thumb=0
Shouldn't these be gathered into a GYP_DEFINES variable?

[hal.canary, 2014-03-25 14:04:38]

https://codereview.chromium.org/211133002/diff/30001/platform_tools/barelinux...
File platform_tools/barelinux/bin/arm64_make (right):

https://codereview.chromium.org/211133002/diff/30001/platform_tools/barelinux...
platform_tools/barelinux/bin/arm64_make:32: BUILD_TYPE='Debug'
On 2014/03/25 13:38:55, borenet wrote:
> We support the following in our "make" builds:
> 
> $ make tests BUILDTYPE=Debug
> 
> Does it make sense to support a similar syntax here?  Or rename the variable
to
> match and only overwrite it if it's not already defined?  That way, we could
do
> something like:
> 
> $ BUILDTYPE=Debug arm64_make tests

(discussed in person why I did this:  parsing arguments in the form KEY=VALUE is
a pain, and passing in environment from python is a pain.)

https://codereview.chromium.org/211133002/diff/30001/platform_tools/barelinux...
platform_tools/barelinux/bin/arm64_make:53: arm_thumb=0
On 2014/03/25 13:38:55, borenet wrote:
> Shouldn't these be gathered into a GYP_DEFINES variable?

Done.

[borenet, 2014-03-25 15:35:33]

LGTM

[hal.canary, 2014-03-25 15:37:13]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-03-25 15:37:18]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/halcanary@google.com/211133002/90001

[commit-bot: I haz the power, 2014-03-25 15:37:38]

Change committed as 13937