platform_tools/barelinux/bin/arm64_make script

platform_tools/barelinux/bin/arm64_make

+#!/bin/sh
+
+# Copyright 2014 Google Inc.
+#
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+usage() {
+    cat >&2 <<EOF
+arm64_make - this script builds a ARMv7 Aarch64 version of skia that
+does not depend on external libraries, perfect for putting in an
+embedded system running Linux.
+
+Assumes that you have already run the download_deps script.
+
+Usage:
+  $0 \\
+    [-o SKIA_OUT_DIR] [-c CC_EXE] [-x CXX_EXE] \\
+    [-t Debug | Release | Coverage | Release_Developer] \\
+
+Example use:
+  $0 \\
+    -o ~/build/skia/arg64gcc \\
+    -c ~/local/arm64/bin/aarch64-linux-gnu-gcc \\
+    -x ~/local/arm64/bin/aarch64-linux-gnu-g++ \\
+EOF
+    return 1
+}
+
+# BUILD_TYPE should be one of:
+#  Coverage, Debug, Release, or Release_Developer
+BUILD_TYPE='Debug'

[borenet, 2014/03/25 13:38:55]

We support the following in our "make" builds:

$ make tests BUILDTYPE=Debug

Does it make sense to support a similar syntax here?  Or rename the variable to
match and only overwrite it if it's not already defined?  That way, we could do
something like:

$ BUILDTYPE=Debug arm64_make tests

[hal.canary, 2014/03/25 14:04:38]

(discussed in person why I did this:  parsing arguments in the form KEY=VALUE is
a pain, and passing in environment from python is a pain.) 

+
+while getopts ":c:x:o:t:h" opt ; do
+    case $opt in
+        c)  export CC="$OPTARG" ;;
+        x)  export CXX="$OPTARG" ;;
+        o)  export SKIA_OUT="$OPTARG";;
+        t)  BUILD_TYPE="$OPTARG";;
+        h)  usage || exit;;
+        ?)  echo "unknown option '$OPTARG'" >&2;
+            usage || exit;;
+    esac
+done
+
+"$(dirname "$0")/barelinux_make" \
+    skia_gpu=0 \
+    skia_arch_type=arm \
+    skia_arch_width=64 \
+    armv7=1 \
+    armv8=1 \
+    arm_neon=0 \
+    arm_thumb=0

[borenet, 2014/03/25 13:38:55]

Shouldn't these be gathered into a GYP_DEFINES variable?

[hal.canary, 2014/03/25 14:04:38]

Done.

+