Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 2111243002: Add docstring for AbstractParallelRebaselineCommand._rebaseline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
index 42f0bb237abeef559ab67b80ff281fd0f4077ad8..1c48f305bd2036a0ede0922b8b8b2af37288ebf1 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
@@ -494,6 +494,22 @@ class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand):
return lines_to_remove
def _rebaseline(self, options, test_prefix_list):
+ """Downloads new baselines in parallel, then updates expectations files
+ and optimizes baselines.
+
+ Args:
+ options: An object with the options passed to the current command.
+ test_prefix_list: A map of test names to builder names to baseline
+ suffixes to rebaseline. For example:
+ {
+ "some/test.html": {"builder-1": ["txt"], "builder-2": ["txt"]},
+ "some/other.html": {"builder-1": ["txt"]}
+ }
+ This would mean that new text baselines should be downloaded for
+ "some/test.html" on both builder-1 and builder-2, and new text
+ baselines should be downloaded for "some/other.html" but only
+ from builder-1.
+ """
for test, builders_to_check in sorted(test_prefix_list.items()):
_log.info("Rebaselining %s" % test)
for builder, suffixes in sorted(builders_to_check.items()):
@@ -564,6 +580,7 @@ class RebaselineExpectations(AbstractParallelRebaselineCommand):
return tests_to_rebaseline
def _add_tests_to_rebaseline_for_port(self, port_name):
+ """Adds tests to self._test_prefix_list for the given port."""
wkorman 2016/06/30 19:17:12 Which tests does it add?
qyearsley 2016/06/30 21:20:39 I believe it's tests that appear in the TestExpect
builder_name = self._tool.builders.builder_name_for_port_name(port_name)
if not builder_name:
return
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698