Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2111243002: Add docstring for AbstractParallelRebaselineCommand._rebaseline. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 5 months ago
Reviewers:
wkorman
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add docstring for AbstractParallelRebaselineCommand._rebaseline. Committed: https://crrev.com/95165a791557990f65f3dc38dd459d99ae175c88 Cr-Commit-Position: refs/heads/master@{#403479}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed docstring for _add_tests_to_rebaseline_for_port for this CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
qyearsley
4 years, 5 months ago (2016-06-30 17:57:05 UTC) #2
wkorman
lgtm https://codereview.chromium.org/2111243002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py File third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py (right): https://codereview.chromium.org/2111243002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py#newcode583 third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py:583: """Adds tests to self._test_prefix_list for the given port.""" ...
4 years, 5 months ago (2016-06-30 19:17:12 UTC) #3
qyearsley
https://codereview.chromium.org/2111243002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py File third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py (right): https://codereview.chromium.org/2111243002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py#newcode583 third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py:583: """Adds tests to self._test_prefix_list for the given port.""" On ...
4 years, 5 months ago (2016-06-30 21:20:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111243002/20001
4 years, 5 months ago (2016-06-30 21:21:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/255926)
4 years, 5 months ago (2016-07-01 00:16:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111243002/20001
4 years, 5 months ago (2016-07-01 16:33:44 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 17:48:21 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 17:50:35 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95165a791557990f65f3dc38dd459d99ae175c88
Cr-Commit-Position: refs/heads/master@{#403479}

Powered by Google App Engine
This is Rietveld 408576698