Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 211123002: CSS Transforms: Implement transform-style (Closed)

Created:
6 years, 9 months ago by dstockwell
Modified:
6 years, 9 months ago
Reviewers:
eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, eseidel, esprehn, abarth-chromium, ojan, Julien - ping for review
Visibility:
Public.

Description

CSS Transforms: Implement transform-style Implements transform-style as defined in CSS Transforms[1]. Behavior is identical to -webkit-transform-style. Note, this property is guarded by the CSSTransformsUnprefixed runtime feature (enabled only for testing). [1] http://www.w3.org/TR/css3-transforms/ BUG=154772 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170305

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove header from helper. #

Patch Set 3 : #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -3 lines) Patch
A LayoutTests/transforms/resources/parsing-test-helper.js View 1 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/transforms/transform-style-parsing.html View 1 chunk +17 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 3 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 3 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
dstockwell
Depends on: https://codereview.chromium.org/211033002/
6 years, 9 months ago (2014-03-25 13:34:42 UTC) #1
eseidel
lgtm https://codereview.chromium.org/211123002/diff/1/LayoutTests/transforms/resources/parsing-test-helper.js File LayoutTests/transforms/resources/parsing-test-helper.js (right): https://codereview.chromium.org/211123002/diff/1/LayoutTests/transforms/resources/parsing-test-helper.js#newcode1 LayoutTests/transforms/resources/parsing-test-helper.js:1: // Copyright 2014 The Chromium Authors. All rights ...
6 years, 9 months ago (2014-03-25 13:37:12 UTC) #2
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-26 03:01:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211123002/150001
6 years, 9 months ago (2014-03-26 03:02:07 UTC) #4
dstockwell
The CQ bit was unchecked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-26 03:09:22 UTC) #5
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-26 03:09:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211123002/150001
6 years, 9 months ago (2014-03-26 03:09:41 UTC) #7
commit-bot: I haz the power
Change committed as 170013
6 years, 9 months ago (2014-03-26 04:04:05 UTC) #8
vsevik
A revert of this CL has been created in https://codereview.chromium.org/212563007/ by vsevik@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-26 13:17:33 UTC) #9
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-27 10:44:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211123002/230001
6 years, 9 months ago (2014-03-27 10:45:05 UTC) #11
commit-bot: I haz the power
Change committed as 170166
6 years, 9 months ago (2014-03-27 11:49:14 UTC) #12
alancutter (OOO until 2018)
A revert of this CL has been created in https://codereview.chromium.org/215843003/ by alancutter@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-28 00:09:45 UTC) #13
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 08:22:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211123002/250001
6 years, 9 months ago (2014-03-28 08:22:16 UTC) #15
dstockwell
The CQ bit was unchecked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 08:22:21 UTC) #16
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 08:22:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211123002/250001
6 years, 9 months ago (2014-03-28 08:23:16 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 09:39:40 UTC) #19
Message was sent while issue was closed.
Change committed as 170305

Powered by Google App Engine
This is Rietveld 408576698