Chromium Code Reviews
DescriptionTrack if a panel is shown in onClosed and peekPanel
When a panel is requested to show, it may not be visible yet and
isShowing will return false. If two panels try to show simultaneously
this can cause the incorrect panel to appear. This change keeps track
of whether peek has been called so there can be a corresponding close
call, regardless of panel visibility. closePanel(...) and
requestPanelShow(...) are not used in every case that closes or opens
the panel; the close and peek methods are used instead.
BUG=624054, 623017
Review-Url: https://codereview.chromium.org/2109823002
Cr-Commit-Position: refs/heads/master@{#402843}
(cherry picked from commit 296d30ec054653d9affc1d68981b6c118683272d)
Committed: https://chromium.googlesource.com/chromium/src/+/c48b93ee3a71a592e8ecba2ff6408bc8daeba7be
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||