Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2111213003: Track if a panel is shown in onClosed and peekPanel (Closed)

Created:
4 years, 5 months ago by mdjones
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Track if a panel is shown in onClosed and peekPanel When a panel is requested to show, it may not be visible yet and isShowing will return false. If two panels try to show simultaneously this can cause the incorrect panel to appear. This change keeps track of whether peek has been called so there can be a corresponding close call, regardless of panel visibility. closePanel(...) and requestPanelShow(...) are not used in every case that closes or opens the panel; the close and peek methods are used instead. BUG=624054, 623017 Review-Url: https://codereview.chromium.org/2109823002 Cr-Commit-Position: refs/heads/master@{#402843} (cherry picked from commit 296d30ec054653d9affc1d68981b6c118683272d) Committed: https://chromium.googlesource.com/chromium/src/+/c48b93ee3a71a592e8ecba2ff6408bc8daeba7be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java View 5 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mdjones
4 years, 5 months ago (2016-07-01 15:43:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c48b93ee3a71a592e8ecba2ff6408bc8daeba7be.

Powered by Google App Engine
This is Rietveld 408576698