Track if a panel is shown in onClosed and peekPanel

Track if a panel is shown in onClosed and peekPanel

When a panel is requested to show, it may not be visible yet and
isShowing will return false. If two panels try to show simultaneously
this can cause the incorrect panel to appear. This change keeps track
of whether peek has been called so there can be a corresponding close
call, regardless of panel visibility. closePanel(...) and
requestPanelShow(...) are not used in every case that closes or opens
the panel; the close and peek methods are used instead.

BUG=624054, 623017
Committed: https://crrev.com/296d30ec054653d9affc1d68981b6c118683272d
Cr-Commit-Position: refs/heads/master@{#402843}

[mdjones, 2016-06-28 21:03:35]

Description was changed from

==========
Reset if a panel was shown in onClosed

closePanel(...) is not used in every case that closes the panel. This
change switches the check for if a panel was shown to onClosed to
account for this.

BUG=624054
==========

to

==========
Track if a panel is shown in onClosed and peekPanel

When a panel is requested to show, it may not be visible yet and
isShowing will return false. If two panels try to show simultaneously
this can cause the incorrect panel to appear. This change keeps track
of whether peek has been called so there can be a corresponding close
call, regardless of panel visibility. closePanel(...) and
requestPanelShow(...) are not used in every case that closes or opens
the panel; the close and peek methods are used instead.

BUG=624054, 623017
==========

[mdjones, 2016-06-28 22:58:50]

mdjones@chromium.org changed reviewers:
+ twellington@chromium.org

[mdjones, 2016-06-28 22:58:50]

Reverted last change because it didn't completely fix the problem. ptal

[Theresa, 2016-06-29 00:14:44]

https://codereview.chromium.org/2109823002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
(right):

https://codereview.chromium.org/2109823002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java:215:
// flag for the panel being shown should be set to true here as well.
nit: where else is it set to true? Maybe just drop the "as well"?

[Theresa, 2016-06-29 01:09:30]

lgtm

[mdjones, 2016-06-29 16:28:42]

https://codereview.chromium.org/2109823002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
(right):

https://codereview.chromium.org/2109823002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java:215:
// flag for the panel being shown should be set to true here as well.
On 2016/06/29 00:14:44, Theresa Wellington wrote:
> nit: where else is it set to true? Maybe just drop the "as well"?

Done.

[mdjones, 2016-06-29 16:28:59]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-06-29 16:28:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2109823002/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2016-06-29 16:30:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 17:10:36]

Description was changed from

==========
Track if a panel is shown in onClosed and peekPanel

When a panel is requested to show, it may not be visible yet and
isShowing will return false. If two panels try to show simultaneously
this can cause the incorrect panel to appear. This change keeps track
of whether peek has been called so there can be a corresponding close
call, regardless of panel visibility. closePanel(...) and
requestPanelShow(...) are not used in every case that closes or opens
the panel; the close and peek methods are used instead.

BUG=624054, 623017
==========

to

==========
Track if a panel is shown in onClosed and peekPanel

When a panel is requested to show, it may not be visible yet and
isShowing will return false. If two panels try to show simultaneously
this can cause the incorrect panel to appear. This change keeps track
of whether peek has been called so there can be a corresponding close
call, regardless of panel visibility. closePanel(...) and
requestPanelShow(...) are not used in every case that closes or opens
the panel; the close and peek methods are used instead.

BUG=624054, 623017
==========

[commit-bot: I haz the power, 2016-06-29 17:10:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-29 17:12:13]

Description was changed from

==========
Track if a panel is shown in onClosed and peekPanel

When a panel is requested to show, it may not be visible yet and
isShowing will return false. If two panels try to show simultaneously
this can cause the incorrect panel to appear. This change keeps track
of whether peek has been called so there can be a corresponding close
call, regardless of panel visibility. closePanel(...) and
requestPanelShow(...) are not used in every case that closes or opens
the panel; the close and peek methods are used instead.

BUG=624054, 623017
==========

to

==========
Track if a panel is shown in onClosed and peekPanel

When a panel is requested to show, it may not be visible yet and
isShowing will return false. If two panels try to show simultaneously
this can cause the incorrect panel to appear. This change keeps track
of whether peek has been called so there can be a corresponding close
call, regardless of panel visibility. closePanel(...) and
requestPanelShow(...) are not used in every case that closes or opens
the panel; the close and peek methods are used instead.

BUG=624054, 623017

Committed: https://crrev.com/296d30ec054653d9affc1d68981b6c118683272d
Cr-Commit-Position: refs/heads/master@{#402843}
==========

[commit-bot: I haz the power, 2016-06-29 17:12:15]

Patchset 4 (id:??) landed as
https://crrev.com/296d30ec054653d9affc1d68981b6c118683272d
Cr-Commit-Position: refs/heads/master@{#402843}