Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2111213002: Adding localization files to the mac bundles for CRD. (Closed)

Created:
4 years, 5 months ago by nicholss
Modified:
4 years, 5 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding localization files to the mac bundles for CRD. R=dpranke@chromium.org, sergeyu@chromium.org BUG=622415 Committed: https://crrev.com/91adc09a58f19e2f5d7dfb9e0cc9f513fb133bfc Cr-Commit-Position: refs/heads/master@{#403289}

Patch Set 1 #

Patch Set 2 : Moving all changes behind is_mac checks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -0 lines) Patch
M remoting/host/BUILD.gn View 1 9 chunks +107 lines, -0 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 3 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
nicholss
PTAL
4 years, 5 months ago (2016-06-30 20:23:36 UTC) #2
Dirk Pranke
lgtm. I'm pretty sure someone needs to look at the mac and windows ports and ...
4 years, 5 months ago (2016-06-30 20:39:11 UTC) #3
nicholss
On 2016/06/30 20:39:11, Dirk Pranke wrote: > lgtm. > > I'm pretty sure someone needs ...
4 years, 5 months ago (2016-06-30 20:58:58 UTC) #4
Sergey Ulanov
lgtm
4 years, 5 months ago (2016-06-30 21:01:11 UTC) #5
Dirk Pranke
On 2016/06/30 20:58:58, nicholss wrote: > On 2016/06/30 20:39:11, Dirk Pranke wrote: > > lgtm. ...
4 years, 5 months ago (2016-06-30 21:06:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111213002/20001
4 years, 5 months ago (2016-06-30 21:07:49 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 21:15:52 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 21:19:11 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/91adc09a58f19e2f5d7dfb9e0cc9f513fb133bfc
Cr-Commit-Position: refs/heads/master@{#403289}

Powered by Google App Engine
This is Rietveld 408576698