Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: remoting/host/it2me/BUILD.gn

Issue 2111213002: Adding localization files to the mac bundles for CRD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moving all changes behind is_mac checks. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/host/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//remoting/remoting_enable.gni") 6 import("//remoting/remoting_enable.gni")
7 import("//remoting/remoting_srcs.gni") 7 import("//remoting/remoting_srcs.gni")
8 import("//remoting/remoting_locales.gni")
8 9
9 if (is_win) { 10 if (is_win) {
10 import("//remoting/host/predefines_win.gni") 11 import("//remoting/host/predefines_win.gni")
11 } 12 }
12 if (is_mac) { 13 if (is_mac) {
13 import("//build/config/mac/rules.gni") 14 import("//build/config/mac/rules.gni")
14 } 15 }
15 16
16 source_set("common") { 17 source_set("common") {
17 sources = rebase_path( 18 sources = rebase_path(
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 rebase_path("../win/dpi_aware.manifest", root_build_dir), 70 rebase_path("../win/dpi_aware.manifest", root_build_dir),
70 71
71 # "/NODEFAULTLIB", TODO(zijiehe): Why IgnoreAllDefaultLibraries: true in 72 # "/NODEFAULTLIB", TODO(zijiehe): Why IgnoreAllDefaultLibraries: true in
72 # GYP does not take effect? 73 # GYP does not take effect?
73 "comctl32.lib", 74 "comctl32.lib",
74 ] 75 ]
75 } 76 }
76 } else { 77 } else {
77 if (is_mac) { 78 if (is_mac) {
78 app_target_type = "mac_app_bundle" 79 app_target_type = "mac_app_bundle"
80
81 # remote_assistance_host-InfoPlist.strings
82 foreach(locale, remoting_locales_with_underscores) {
83 bundle_data("remote_assistance_host_strings_${locale}_bundle_data") {
84 sources = [
85 "$root_gen_dir/remoting/host/remote_assistance_host-InfoPlist.string s/$locale.lproj/InfoPlist.strings",
86 ]
87 outputs = [
88 "{{bundle_resources_dir}}/$locale.lproj/{{source_file_part}}",
89 ]
90 deps = [
91 "//remoting/host:remoting_infoplist_strings",
92 ]
93 }
94 }
79 } else { 95 } else {
80 app_target_type = "executable" 96 app_target_type = "executable"
81 } 97 }
82 98
83 target(app_target_type, "remote_assistance_host") { 99 target(app_target_type, "remote_assistance_host") {
84 if (is_mac) { 100 if (is_mac) {
85 info_plist = "remote_assistance_host-Info.plist" 101 info_plist = "remote_assistance_host-Info.plist"
86 extra_configs = [ 102 extra_configs = [
87 "//build/config/compiler:wexit_time_destructors", 103 "//build/config/compiler:wexit_time_destructors",
88 "//remoting:version", 104 "//remoting:version",
(...skipping 12 matching lines...) Expand all
101 ] 117 ]
102 118
103 deps = [ 119 deps = [
104 ":common", 120 ":common",
105 "//build/config/sanitizers:deps", 121 "//build/config/sanitizers:deps",
106 "//remoting/host", 122 "//remoting/host",
107 "//remoting/host/native_messaging", 123 "//remoting/host/native_messaging",
108 "//remoting/proto", 124 "//remoting/proto",
109 "//ui/gfx", 125 "//ui/gfx",
110 ] 126 ]
127 if (is_mac) {
128 foreach(locale, remoting_locales_with_underscores) {
129 deps += [
130 ":remote_assistance_host_strings_${locale}_bundle_data",
131 "//remoting/host:remoting_host_locale_${locale}_bundle_data",
132 ]
133 }
134 deps += [
135 "//remoting/host:remoting_infoplist_strings",
136 "//remoting/resources:copy_locales",
137 ]
138 }
111 139
112 if (enable_webrtc) { 140 if (enable_webrtc) {
113 deps += [ "//third_party/libjingle:libjingle_webrtc" ] 141 deps += [ "//third_party/libjingle:libjingle_webrtc" ]
114 } 142 }
115 143
116 if (is_desktop_linux) { 144 if (is_desktop_linux) {
117 deps += [ "//build/config/linux/gtk2" ] 145 deps += [ "//build/config/linux/gtk2" ]
118 } 146 }
119 } 147 }
120 } 148 }
121 } 149 }
OLDNEW
« no previous file with comments | « remoting/host/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698