Issue 211113002: Oilpan: Move CSSAnimations and CSSAnimationUpdate to oilpan's heap

Issue 211113002: Oilpan: Move CSSAnimations and CSSAnimationUpdate to oilpan's heap (Closed)

Created:
6 years, 9 months ago by haraken

Modified:
6 years, 9 months ago

Reviewers:
oilpan-reviews, wibling-chromium, Mads Ager (chromium)

CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, rune+blink, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Oilpan: Move CSSAnimations and CSSAnimationUpdate to oilpan's heap BUG=341032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169949

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -18 lines)			Patch
M	Source/core/animation/css/CSSAnimations.h	View	6 chunks	+15 lines, -10 lines	0 comments	Download
M	Source/core/animation/css/CSSAnimations.cpp	View	3 chunks	+17 lines, -3 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolverState.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolverState.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

haraken

On 2014/03/25 14:13:50, wibling-chromium wrote: > lgtm Thanks!

6 years, 9 months ago (2014-03-25 14:16:54 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/211113002/1

6 years, 9 months ago (2014-03-25 14:16:59 UTC) #5

haraken

On 2014/03/25 15:18:23, I haz the power (commit-bot) wrote: > Change committed as 169949 Let ...

6 years, 9 months ago (2014-03-26 02:29:13 UTC) #7

haraken

6 years, 9 months ago (2014-03-26 06:16:39 UTC) #8

Message was sent while issue was closed.

On 2014/03/26 02:29:13, haraken wrote:
> On 2014/03/25 15:18:23, I haz the power (commit-bot) wrote:
> > Change committed as 169949
> 
> Let me revert this CL since it broke a bunch of tests in oilpan bots:
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%2520Mac%2520Oilpa...

I noticed that I need to move ActiveAnimations at the same time in this CL,
because ActiveAnimations has CSSAnimations as a part of object.

I uploaded a new CL here: https://codereview.chromium.org/212143002

Expand Messages | Collapse Messages