Issue 212143002: Oilpan: Move CSSAnimations, CSSAnimationUpdate and ActiveAnimations to oilpan's heap

Issue 212143002: Oilpan: Move CSSAnimations, CSSAnimationUpdate and ActiveAnimations to oilpan's heap (Closed)

Created:
6 years, 9 months ago by haraken

Modified:
6 years, 9 months ago

Reviewers:
oilpan-reviews, wibling-chromium, Mads Ager (chromium)

CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, rune+blink, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Oilpan: Move CSSAnimations, CSSAnimationUpdate and ActiveAnimations to oilpan's heap BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170031

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -24 lines)			Patch
M	Source/core/animation/ActiveAnimations.h	View		2 chunks	+6 lines, -2 lines	1 comment	Download
M	Source/core/animation/ActiveAnimations.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/animation/css/CSSAnimations.h	View		6 chunks	+15 lines, -10 lines	1 comment	Download
M	Source/core/animation/css/CSSAnimations.cpp	View		3 chunks	+17 lines, -3 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolverState.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolverState.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/ElementRareData.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/ElementRareData.cpp	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

PTAL https://codereview.chromium.org/212143002/diff/20001/Source/core/animation/ActiveAnimations.h File Source/core/animation/ActiveAnimations.h (right): https://codereview.chromium.org/212143002/diff/20001/Source/core/animation/ActiveAnimations.h#newcode68 Source/core/animation/ActiveAnimations.h:68: typedef HashCountedSet<AnimationPlayer*> AnimationPlayerSet; This raw pointer is safe ...

6 years, 9 months ago (2014-03-26 06:20:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/212143002/20001

6 years, 9 months ago (2014-03-26 07:07:04 UTC) #4

Message was sent while issue was closed.

Change committed as 170031

Expand Messages | Collapse Messages