chrome/browser/chromeos/policy/device_status_collector.cc - Issue 2111103002: Make callers of FromUTC(Local)Exploded in chrome/ use new time API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_status_collector.cc

Issue 2111103002: Make callers of FromUTC(Local)Exploded in chrome/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: modified comments in code Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/banners/app_banner_settings_helper_unittest.cc ('k') | chrome/browser/engagement/site_engagement_score_unittest.cc » ('j') | chrome/browser/password_manager/password_store_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_status_collector.cc

diff --git a/chrome/browser/chromeos/policy/device_status_collector.cc b/chrome/browser/chromeos/policy/device_status_collector.cc

index fdf71837622a40c30c5dd91fe7ad5fa26240213d..4094b49a186fc44c77124c6f2a822160dbf38db3 100644

--- a/chrome/browser/chromeos/policy/device_status_collector.cc

+++ b/chrome/browser/chromeos/policy/device_status_collector.cc

@@ -103,7 +103,13 @@ const char kCPUTempFilePattern[] = "temp*_input";

int64_t TimestampToDayKey(Time timestamp) {

Time::Exploded exploded;

timestamp.LocalMidnight().LocalExplode(&exploded);

- return (Time::FromUTCExploded(exploded) - Time::UnixEpoch()).InMilliseconds();

+ Time out_time;

+ // Returns Time(0) on failure.

+ if (!Time::FromUTCExploded(exploded, &out_time)) {

Lei Zhang 2016/07/06 17:44:29 Can values that come from another Time instance ev

maksims (do not use this acc) 2016/07/07 05:48:14 No, they shouldn't

+ // TODO(maksims): implement failure handling.

+ NOTIMPLEMENTED();

+ }

+ return (out_time - Time::UnixEpoch()).InMilliseconds();

}

// Helper function (invoked via blocking pool) to fetch information about