Chromium Code Reviews| Index: chrome/browser/password_manager/password_store_mac.cc |
| diff --git a/chrome/browser/password_manager/password_store_mac.cc b/chrome/browser/password_manager/password_store_mac.cc |
| index 63dca04ff7d065131de170d116e784a6f6415846..7d4f21aaf5d2501922aea39262809c209c9ebff9 100644 |
| --- a/chrome/browser/password_manager/password_store_mac.cc |
| +++ b/chrome/browser/password_manager/password_store_mac.cc |
| @@ -279,8 +279,7 @@ GURL URLFromComponents(bool is_secure, const std::string& host, int port, |
| } |
| // Converts a Keychain time string to a Time object, returning true if |
| -// time_string_bytes was parsable. If the return value is false, the value of |
| -// |time| is unchanged. |
| +// time_string_bytes was parsable. |
| bool TimeFromKeychainTimeString(const char* time_string_bytes, |
| unsigned int byte_length, |
| base::Time* time) { |
| @@ -299,8 +298,8 @@ bool TimeFromKeychainTimeString(const char* time_string_bytes, |
| free(time_string); |
| if (assignments == 6) { |
|
Lei Zhang
2016/07/06 17:44:30
This can just be:
return assignments == 6 && base:
maksims (do not use this acc)
2016/07/07 05:48:14
Done.
|
| - *time = base::Time::FromUTCExploded(exploded_time); |
| - return true; |
| + if (base::Time::FromUTCExploded(exploded_time, time)) |
| + return true; |
| } |
| return false; |
| } |